Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grammer in indices/refresh.asciidoc #50759

Merged
merged 2 commits into from
Jan 9, 2020
Merged

Fix grammer in indices/refresh.asciidoc #50759

merged 2 commits into from
Jan 9, 2020

Conversation

mattayes
Copy link
Contributor

@mattayes mattayes commented Jan 8, 2020

Changes

  • Fix grammer issue in indices/refresh.asciidoc.

@cbuescher cbuescher added the >docs General docs changes label Jan 9, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

jrodewig
jrodewig approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this @mattayes.

@jrodewig
Copy link
Contributor

jrodewig commented Jan 9, 2020

@elasticmachine test this please

@jrodewig jrodewig added the :Data Management/Indices APIs APIs to create and manage indices and templates label Jan 9, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Indices APIs)

jrodewig
jrodewig suggested changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattayes I made a small suggestion that should fix it. After rereading, I believe your fix has a subject/verb agreement issue.

@mattayes @jrodewig
Update docs/reference/indices/refresh.asciidoc
8ffa05d 
Co-Authored-By: James Rodewig <james.rodewig@elastic.co>
@mattayes
Copy link
Contributor Author

mattayes commented Jan 9, 2020

@jrodewig Change made.

jrodewig
jrodewig approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mattayes!

@jrodewig
Copy link
Contributor

jrodewig commented Jan 9, 2020

@elasticmachine test this please

@jrodewig jrodewig merged commit 5d289e3 into elastic:master Jan 9, 2020
jrodewig pushed a commit that referenced this pull request Jan 9, 2020
@mattayes @jrodewig
[DOCS] Fix typo in refresh API docs (#50759)
344c218
jrodewig pushed a commit that referenced this pull request Jan 9, 2020
@mattayes @jrodewig
[DOCS] Fix typo in refresh API docs (#50759)
c3fa878
@jrodewig
Copy link
Contributor

jrodewig commented Jan 9, 2020

Backport commits

master: 5d289e3
7.x: 344c218
7.5: c3fa878

@mattayes
Copy link
Contributor Author

mattayes commented Jan 9, 2020

Thanks for the quick review/merge @jrodewig!

SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
@mattayes @SivagurunathanV
Fix typo in refresh API docs (elastic#50759)
e8602cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrodewig jrodewig jrodewig approved these changes

Assignees
No one assigned
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates >docs General docs changes v7.5.2 v7.6.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mattayes @elasticmachine @jrodewig @jakelandis @cbuescher