Explicitly require a OriginSettingClient in ML results iterators #50802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml) |
davidkyle
changed the title
|
Please can you also backport this to 7.x rather than just changing master, as it will avoid future backporting pain to avoid unnecessary differences between master and 7.x |
|
The unit tests proved quite problematic as |
In classes where the client is used directly rather than executeAsyncWithOrigin and remove calls to deprecated ClientHelper.clientWithOrigin() method
davidkyle
force-pushed
the
make-client0-with-origin-explicit
branch
from
276badd
to
d12fdb6
Compare
davidkyle
added a commit
to davidkyle/elasticsearch
that referenced
this pull request
Jan 14, 2020
…stic#50802) In classes where the client is used directly rather than through a call to executeAsyncWithOrigin explicitly require the client to be OriginSettingClient rather than using the Client interface. Also remove calls to deprecated ClientHelper.clientWithOrigin() method.
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
…stic#50802) In classes where the client is used directly rather than through a call to executeAsyncWithOrigin explicitly require the client to be OriginSettingClient rather than using the Client interface. Also remove calls to deprecated ClientHelper.clientWithOrigin() method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In classes where the client is used directly rather than through a call to
executeAsyncWithOriginexplicitly require the client to beOriginSettingClientrather than use theclientinterface. Basically that meansBatchedDocumentsIteratorand the classes that use it.Also remove calls to deprecated ClientHelper.clientWithOrigin() method.