Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hardcoded version replacement in put-dfanalytics.asciidoc #51056

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

davidkyle
Copy link
Member

The substitution must match the whitespace in the console result.

Inspired by #51053 this is the same fix on master for the inevitable failure when 8.0 is released.

@davidkyle davidkyle added >docs General docs changes :ml Machine learning v8.0.0 labels Jan 15, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkyle davidkyle merged commit 5ad1d0d into elastic:master Jan 16, 2020
@davidkyle davidkyle deleted the df-analytics-docs-substitution branch January 16, 2020 10:06
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :ml Machine learning v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants