Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove translog retention settings #51697

Merged
merged 3 commits into from
Jan 31, 2020
Merged

Remove translog retention settings #51697

merged 3 commits into from
Jan 31, 2020

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Jan 30, 2020

The translog retention settings index.translog.retention.size and index.translog.retention.age were effectively ignored in 7.4, deprecated in 7.7, and now removed in 8.0 in favor of soft-deletes.

Closes #50775

@dnhatn dnhatn added >breaking :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. v8.0.0 labels Jan 30, 2020
@dnhatn dnhatn requested review from ywelsch and jrodewig January 30, 2020 19:28
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Engine)

@dnhatn dnhatn changed the title Reject translog retention settings Remove translog retention settings Jan 30, 2020
@dnhatn dnhatn mentioned this pull request Jan 30, 2020
Closed
14 tasks
ywelsch
ywelsch approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn
Copy link
Member Author

dnhatn commented Jan 31, 2020

Thanks Yannick.

@dnhatn dnhatn merged commit 6e0fbbd into elastic:master Jan 31, 2020
@dnhatn dnhatn deleted the remove-translog-retention-settings branch January 31, 2020 13:18
@jtibshirani jtibshirani mentioned this pull request Jan 21, 2021
Open
@jakelandis jakelandis mentioned this pull request Feb 22, 2021
Closed
fcofdez added a commit to fcofdez/elasticsearch that referenced this pull request May 31, 2021
@fcofdez
Add deprecation flags to INDEX_TRANSLOG_RETENTION_SIZE_SETTING and IN…
e52603d 
…DEX_TRANSLOG_RETENTION_AGE_SETTING

Relates elastic#51697
@fcofdez fcofdez mentioned this pull request May 31, 2021
Closed
@jrodewig jrodewig mentioned this pull request Sep 15, 2021
Merged
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for translog retention settings (#77814)
85c6536 
We deprecated the translog retention settings in 7.7 with PR #45473.
However, we didn't add a related item to the 7.7 breaking changes docs. This adds
the missing item.

Relates to #51697.
elasticsearchmachine pushed a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for translog retention settings (#77814) (#…
fe31be9 
…77908)

We deprecated the translog retention settings in 7.7 with PR #45473.
However, we didn't add a related item to the 7.7 breaking changes docs. This adds
the missing item.

Relates to #51697.
elasticsearchmachine pushed a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for translog retention settings (#77814) (#…
152ac94 
…77909)

We deprecated the translog retention settings in 7.7 with PR #45473.
However, we didn't add a related item to the 7.7 breaking changes docs. This adds
the missing item.

Relates to #51697.
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for translog retention settings (#77814) (#…
8f795b0 
…77910)

We deprecated the translog retention settings in 7.7 with PR #45473.
However, we didn't add a related item to the 7.7 breaking changes docs. This adds
the missing item.

Relates to #51697.
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for translog retention settings (#77814) (#…
75348bd 
…77916)

We deprecated the translog retention settings in 7.7 with PR #45473.
However, we didn't add a related item to the 7.7 breaking changes docs. This adds
the missing item.

Relates to #51697.
elasticsearchmachine pushed a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for translog retention settings (#77814) (#…
3353597 
…77912)

We deprecated the translog retention settings in 7.7 with PR #45473.
However, we didn't add a related item to the 7.7 breaking changes docs. This adds
the missing item.

Relates to #51697.
elasticsearchmachine pushed a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for translog retention settings (#77814) (#…
f86f641 
…77913)

We deprecated the translog retention settings in 7.7 with PR #45473.
However, we didn't add a related item to the 7.7 breaking changes docs. This adds
the missing item.

Relates to #51697.
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for translog retention settings (#77814) (#…
dc493b2 
…77911)

We deprecated the translog retention settings in 7.7 with PR #45473.
However, we didn't add a related item to the 7.7 breaking changes docs. This adds
the missing item.

Relates to #51697.
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for translog retention settings (#77814) (#…
d449092 
…77914)

We deprecated the translog retention settings in 7.7 with PR #45473.
However, we didn't add a related item to the 7.7 breaking changes docs. This adds
the missing item.

Relates to #51697.
jrodewig added a commit that referenced this pull request Sep 16, 2021
@jrodewig
[DOCS] Add deprecation docs for translog retention settings (#77814) (#…
cbaf61a 
…77915)

We deprecated the translog retention settings in 7.7 with PR #45473.
However, we didn't add a related item to the 7.7 breaking changes docs. This adds
the missing item.

Relates to #51697.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywelsch ywelsch ywelsch approved these changes

@jrodewig jrodewig Awaiting requested review from jrodewig

Assignees
No one assigned
Labels
>breaking :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make soft-deletes mandatory
4 participants
@dnhatn @elasticmachine @ywelsch @jakelandis