Add support for filters to T-Test aggregation #54980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for filters to T-Test aggregation. The filters can be used to select populations based on some criteria and use values from the same or different fields. Closes elastic#53692
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
|
@elasticmachine update branch |
polyfractal
reviewed
Apr 9, 2020
| return new PairedTTestAggregator(name, numericMultiVS, tails, format, searchContext, parent, metadata); | ||
| case HOMOSCEDASTIC: | ||
| return new UnpairedTTestAggregator(name, numericMultiVS, tails, true, format, searchContext, parent, metadata); | ||
| return new UnpairedTTestAggregator(name, numericMultiVS, tails, true, this::getWeights, format, searchContext, parent, |
There was a problem hiding this comment.
Should we validate/throw an exception/something if people specify an unpaired type, but don't provide filters? Not sure where to put that validation logic but it seems we should disallow folks from basically running an unpaired test on two match-all's?
There was a problem hiding this comment.
I was thinking about support for something like this:
{"before": [1,2,3], "after":[6,7,8,9,10]}
It currently works for unpaired, fails on paired and doesn't require filters.
polyfractal
approved these changes
Apr 9, 2020
|
@elasticmachine update branch |
imotov
added a commit
to imotov/elasticsearch
that referenced
this pull request
Apr 10, 2020
Adds support for filters to T-Test aggregation. The filters can be used to select populations based on some criteria and use values from the same or different fields. Closes elastic#53692
imotov
added a commit
that referenced
this pull request
Apr 13, 2020
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for filters to T-Test aggregation. The filters can be used to
select populations based on some criteria and use values from the same or
different fields.
Closes #53692