Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Creating Compatible API rest requests in xpack #59993

Closed
wants to merge 2 commits into from
Closed

WIP Creating Compatible API rest requests in xpack #59993

wants to merge 2 commits into from

Conversation

pgomulka
Copy link
Contributor

@pgomulka pgomulka commented Jul 21, 2020 •
edited
Loading

RestRequest objects are now created in AbstractHttpServerTransport with a static factory method. This PR is refactoring to use a RestRequestFactory which can be defaulted to RestRequest::request in oss but overriden with a different factory in xpack.

relates #51816 (main meta compat API issue)

@pgomulka pgomulka added :Core/Infra/REST API REST infrastructure and utilities v8.0.0 labels Jul 21, 2020
@pgomulka pgomulka self-assigned this Jul 21, 2020
@pgomulka pgomulka requested a review from jakelandis July 21, 2020 16:32
@pgomulka
Copy link
Contributor Author

pgomulka commented Sep 8, 2020

closing in favour of #60516

@pgomulka pgomulka closed this Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelandis jakelandis Awaiting requested review from jakelandis

Assignees
No one assigned
Labels
:Core/Infra/REST API REST infrastructure and utilities v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pgomulka @jakelandis