Handle incorrect header values #64708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Accept or Content-Type header values are incorrect, a request should be gracefully rejected and an exception message returned to a client. relates elastic#64689
|
Pinging @elastic/es-core-infra (:Core/Infra/REST API) |
jakelandis
reviewed
Nov 6, 2020
|
|
||
| @Override | ||
| public void dispatchBadRequest(RestChannel channel, ThreadContext threadContext, Throwable cause) { | ||
| assertThat(cause, instanceOf(RestRequest.MediaTypeHeaderException.class)); |
There was a problem hiding this comment.
Is there anywhere that we can assert that the header name at fault is included in the error sent back to the user ?
There was a problem hiding this comment.
great you noticed this. in fact the header name was not surfaced on a response.
I refactored this to return something like
{
"error": {
"root_cause": [
{
"type": "media_type_header_exception",
"reason": "Invalid media-type value on header [Accept]"
}
],
"type": "media_type_header_exception",
"reason": "Invalid media-type value on header [Accept]",
"caused_by": {
"type": "illegal_argument_exception",
"reason": "invalid media type [texffff]"
}
},
"status": 400
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Accept or Content-Type header values are incorrect, a request
should be gracefully rejected and an exception message returned to a
client.
relates #64689
relates #51816