Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bucket.asciidoc #73306

Merged
merged 1 commit into from
May 26, 2021
Merged

Update bucket.asciidoc #73306

merged 1 commit into from
May 26, 2021

Conversation

nephel
Copy link

@nephel nephel commented May 21, 2021

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@elasticsearchmachine elasticsearchmachine added the external-contributor Pull request authored by a developer outside the Elasticsearch team label May 21, 2021
@pgomulka pgomulka added :Analytics/Aggregations Aggregations >docs General docs changes labels May 24, 2021
@elasticmachine elasticmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team labels May 24, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@nik9000 nik9000 requested a review from imotov May 24, 2021 18:15
imotov
imotov approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@imotov imotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is technically a bug, which is fixed in 7.x and above, but since we are not going to fix it, we can as well document the actual behavior. LGTM

@imotov
Copy link
Contributor

imotov commented May 25, 2021

@elasticmachine run elasticsearch-ci/docs

@imotov
Copy link
Contributor

imotov commented May 25, 2021

@elasticmachine test this please

@imotov imotov merged commit 4c5f2e4 into 6.8 May 26, 2021
@imotov imotov deleted the nephel-patch-1 branch May 26, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imotov imotov imotov approved these changes

Assignees
No one assigned
Labels
:Analytics/Aggregations Aggregations >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nephel @elasticmachine @imotov @pgomulka @elasticsearchmachine