[7.15] Handle master failure in NodeSeenService (#77220) #77528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Handle master failure in NodeSeenService NodeSeenService can miss seeing nodes if the master changes while it's processing the cluster state update which adds the nodes to the cluster. This caused occasional test failures in the test intended to check that NodeSeenService is working as intended. This commit adjusts NodeSeenService's early returns to ensure that, if the master changed, the new master checks for seen nodes even if nodes were not added in that particular cluster state update. * Clarify & correct "just-became-master" check * Remove leftover debug logging (d'oh!) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gwbrown
added
auto-merge-without-approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.15: