More consistent naming for term vector[s] #8484
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We speak of the term vectors of a document, where each field has an associated stored term vector. Since by default we are requesting all the term vectors of a document, the HTTP request endpoint should rather be called `_termvectors` instead of `_termvector`. The usage of `_termvector` is now deprecated, as well as the transport client call to termVector and prepareTermVector.
|
The change looks good to me. @clintongormley Could you just confirm that it's ok to break it for 2.0? |
|
@jpountz +1 - the old |
|
Shouldn't this be marked as "breaking" since it breaks the Java API compatibility? |
|
The old usage is still supported though. |
|
Yes, for the REST side, on the Java side, TermVectorRequestBuilder became TermVectorsRequestBuilder and TermVectorResponse became TermVectorsResponse, which will cause compilation errors for Java API users |
|
On the Java client side you can still call on Client#termVector, but I agree for the other classes. So I'll mark it as breaking. Thanks! |
clintongormley
changed the title
clintongormley
added
:Search/Search
jtibshirani
added a commit
that referenced
this pull request
Nov 30, 2018
This endpoint was replaced by _termvectors (plural) in #8484. We deprecated the relevant transport client methods, but didn't introduce a deprecation warning. My plan was to add a deprecation warning in 6.6, and stop supporting this endpoint in 7.0.
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We speak of the term vectors of a document, where each field has an associated
stored term vector. Since by default we are requesting all the term vectors of
a document, the HTTP request endpoint should rather be called
_termvectorsinstead of
_termvector. The usage of_termvectoris now deprecated, aswell as the transport client call to termVector and prepareTermVector.