Skip to content

Commit

Permalink
Add control columns to EuiDataGrid (#2846)
Browse files Browse the repository at this point in the history
* Added action column type to EuiDataGrid; created a row selection demo

* Renamed action columns to control columns, finished functionality, demo, and docs

* Don't allow control columns to be expandable

* Added a render test for data grid control columns

* allow classNames on more inner grid components and make truncation skip control columns

* snaps

* flyout example

* removed selection highlighting from demo

* cleanup docs and styling

* undo an accidental change that snuck in

* changelog

* fix docs

* AriaAttributes instead of HTMLAttribute<T> to access aria attributes

Co-authored-by: dave.snider@gmail.com <dave.snider@gmail.com>
  • Loading branch information
chandlerprall and snide authored Feb 19, 2020
1 parent f11ea60 commit 22c983b
Show file tree
Hide file tree
Showing 21 changed files with 1,985 additions and 279 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
- Exported `EuiSelectOptionProps` type ([#2830](https://github.com/elastic/eui/pull/2830))
- Added `paperClip` glyph to `EuiIcon` ([#2845](https://github.com/elastic/eui/pull/2845))
- Added `banner` prop to `EuiFlyoutBody` and updated `euiOverflowShadow` mixin ([#2837](https://github.com/elastic/eui/pull/2837))
- Added control columns to `EuiDataGrid` to support non-data columns like row selection and actions ([#2846](https://github.com/elastic/eui/pull/2846))

**Bug fixes**

Expand Down
2 changes: 2 additions & 0 deletions src-docs/src/routes.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ import { DataGridExample } from './views/datagrid/datagrid_example';
import { DataGridMemoryExample } from './views/datagrid/datagrid_memory_example';
import { DataGridSchemaExample } from './views/datagrid/datagrid_schema_example';
import { DataGridStylingExample } from './views/datagrid/datagrid_styling_example';
import { DataGridControlColumnsExample } from './views/datagrid/datagrid_controlcolumns_example';

import { DatePickerExample } from './views/date_picker/date_picker_example';

Expand Down Expand Up @@ -341,6 +342,7 @@ const navigation = [
DataGridMemoryExample,
DataGridSchemaExample,
DataGridStylingExample,
DataGridControlColumnsExample,
TableExample,
].map(example => createExample(example)),
},
Expand Down
Loading

0 comments on commit 22c983b

Please sign in to comment.