Skip to content

Commit

Permalink
chore: cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
mgadewoll committed Nov 29, 2024
1 parent b8b730d commit 8843ba7
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion packages/eui/changelogs/upcoming/8195.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@

- Improved the accessibility of `EuiCodeBlock`s by
- adding screen reader only labels
- adding `role="dialog` on in fullscreen mode
- adding `role="dialog"` on in fullscreen mode
- ensuring focus is returned on closing fullscreen mode

2 changes: 0 additions & 2 deletions packages/eui/src/components/code/code_block_full_screen.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,6 @@ export const EuiCodeBlockFullScreenWrapper: FunctionComponent<
'Expanded code block'
);

// the fullscreen element is fullscreen and has a focus trap, mark it as dialog
// to ensure expected semantic definition and behavior for screen readers
const dialogProps = {
role: 'dialog',
'aria-modal': true,
Expand Down

0 comments on commit 8843ba7

Please sign in to comment.