From 8843ba7569018c143e6835bc00f6962d8aaa341f Mon Sep 17 00:00:00 2001 From: Lene Gadewoll Date: Fri, 29 Nov 2024 17:21:11 +0100 Subject: [PATCH] chore: cleanup --- packages/eui/changelogs/upcoming/8195.md | 2 +- packages/eui/src/components/code/code_block_full_screen.tsx | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/eui/changelogs/upcoming/8195.md b/packages/eui/changelogs/upcoming/8195.md index fdf604fcfaa..8fe7b3a2f3b 100644 --- a/packages/eui/changelogs/upcoming/8195.md +++ b/packages/eui/changelogs/upcoming/8195.md @@ -2,6 +2,6 @@ - Improved the accessibility of `EuiCodeBlock`s by - adding screen reader only labels - - adding `role="dialog` on in fullscreen mode + - adding `role="dialog"` on in fullscreen mode - ensuring focus is returned on closing fullscreen mode diff --git a/packages/eui/src/components/code/code_block_full_screen.tsx b/packages/eui/src/components/code/code_block_full_screen.tsx index e7a5680c92b..52de94ae276 100644 --- a/packages/eui/src/components/code/code_block_full_screen.tsx +++ b/packages/eui/src/components/code/code_block_full_screen.tsx @@ -133,8 +133,6 @@ export const EuiCodeBlockFullScreenWrapper: FunctionComponent< 'Expanded code block' ); - // the fullscreen element is fullscreen and has a focus trap, mark it as dialog - // to ensure expected semantic definition and behavior for screen readers const dialogProps = { role: 'dialog', 'aria-modal': true,