From b23c9d7020526df7b5f971e2cae32e9a9246f9c5 Mon Sep 17 00:00:00 2001 From: Leonel Jara Date: Tue, 21 Sep 2021 17:47:55 -0400 Subject: [PATCH] [EuiButtonGroup] Add `title` when in `iconOnly` mode (#5199) * Add title when in iconOnly mode using label * Update button_group snapshot * Update CHANGELOG.md * Move title prop out of textprops * Update CHANGELOG.md Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> --- CHANGELOG.md | 1 + src/components/button/button_group/button_group_button.tsx | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 20c1eba4bae..ae33aff8b1d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,6 @@ ## [`master`](https://github.com/elastic/eui/tree/master) +- Fixed the `title` prop `EuiButtonGroup` to automatically display the `label` provided ([#5199](https://github.com/elastic/eui/pull/5199)) - Updated `barSeriesStyle.displayValue` of the elastic-charts `Theme` for better default styles ([#4845](https://github.com/elastic/eui/pull/4845)) - Added `auto` as value for `defaultHeight` in prop `rowHeightsOptions` in `EuiDataGrid` that allows to content auto-fit to row ([#4958](https://github.com/elastic/eui/pull/4958)) - Updated `titleProps` and `descriptionProps` on `EuiDescriptionList` to extend `CommonProps` ([#5166](https://github.com/elastic/eui/pull/5166)) diff --git a/src/components/button/button_group/button_group_button.tsx b/src/components/button/button_group/button_group_button.tsx index 19d4376a6b3..422074ddd80 100644 --- a/src/components/button/button_group/button_group_button.tsx +++ b/src/components/button/button_group/button_group_button.tsx @@ -127,8 +127,8 @@ export const EuiButtonGroupButton: FunctionComponent = ({ : 'euiButtonGroupButton__textShift', ref: buttonTextRef, 'data-text': innerText, - title: innerText, }} + title={innerText} {...elementProps} {...rest} >