-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown Widget #1491
Comments
note that this has been developed for the Dream Machine project here: https://github.com/elastic/dream-machine/pull/141 could be a decent starting-off point |
@i-a-n if you wanted to kickstart a PR when you're happy with it, we could take it over and clean up design / accessibility and likely CSP issues that will arise. There's definitely a want for this component, but my guess is it would take a few weeks to get polished where we'd feel comfortable having usage in a place like cloud and you likely don't have time for all the touchup work. But by all means give us a start with what you've got and we can do some work on it. |
sounds good @snide , thanks. I have one outstanding issue to resolve regarding how the text insertion works, but once that's complete I'll open a PR here. |
Are there any strong feelings on what the preview button should say? @inqueue suggested |
This will likely go through a few rounds of design. I wouldn't worry too much about the layout or text. We can clean it up during a design pass. |
With #2858 moving forward, closing this one. |
This is an issue for a requested new control within EUI: a Markdown-wrapper.
Specifically, I would love to be able to pass something close to if not identical to GitHub Markdown. This may not align very well with existing Kibana Markdown needs though, and I can see certain desirable limitations (e.g., not supporting images).
Imagine this kind of text coming in:
Beyond that our native blockquote CSS looks very different, this should render as something like
The text was updated successfully, but these errors were encountered: