You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This change has caused a slight regression for consumers of combo box. In our use case, we perform validation of the combo box and display an error message once the user has tabbed away. If the user just tabs to the clear button, then the combo box appears invalid but without any information for the user:
Once they've tabbed away completely, they get the information they need:
If we could revert the change I linked to I believe that would restore the desired behavior. CC @chandlerprall
The text was updated successfully, but these errors were encountered:
As a sidenote, the combo box attempts to "submit" any input for conversion into a pill once the user tabs away, which should make the markAsInvalid logic unnecessary, I think.
After talking this over with @chandlerprall I understand that the intention behind the change was to surface an error for combo boxes where custom options have been disallowed, since this is the only scenario where this UX is relevant.
I think my original issue from the above screenshot can be addressed by removing the red underline invalid state when the user is still interacting with the combo box, e.g. has focused on the clear button. Then this behavior of showing an invalid state when there's lingering input won't even be manifested in my use case.
Beyond that, I'd suggest two additional changes:
Some comments around the code I linked to, explaining the intended UX in the context of the combo boxes which disallow custom options.
Update the docs in the screenshot with some error text to explain how the user can fix the invalid state, e.g. "Please select an option or delete your search." Though this does seem like a bit of a hassle for the user.
This change has caused a slight regression for consumers of combo box. In our use case, we perform validation of the combo box and display an error message once the user has tabbed away. If the user just tabs to the clear button, then the combo box appears invalid but without any information for the user:
Once they've tabbed away completely, they get the information they need:
If we could revert the change I linked to I believe that would restore the desired behavior. CC @chandlerprall
The text was updated successfully, but these errors were encountered: