Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiCheckbox - add support for indeterminate #239

Closed
uboness opened this issue Dec 21, 2017 · 7 comments
Closed

EuiCheckbox - add support for indeterminate #239

uboness opened this issue Dec 21, 2017 · 7 comments
Assignees

Comments

@uboness
Copy link
Contributor

uboness commented Dec 21, 2017

Often a top-level checkbox is used in lists/tables to de/select all items. When only some of the items are check, it'd be nice if we can set that top level checkbox to indeterminate state and have a clear visual indicator for the partial selection (basically make sure that visually the checkbox is consistent with it's functional purpose)

@snide
Copy link
Contributor

snide commented Dec 22, 2017

@snide
Copy link
Contributor

snide commented Dec 22, 2017

Browsers seem to be inconsistent with this, so I figured it's OK to go with our own style here. Path of least resistance is to show a "half" filled checkbox.

I don't like using the "minus" style because that symbol is often used for warnings. I figure either of the below provides a better "partial" representation.

Also. It looks like this isn't an HTML attr but a JS one, so I figured its OK to just use CSS through an "indeterminate" prop. Lemme know if this works and I'll set up a PR.

image

image

@cchaos
Copy link
Contributor

cchaos commented Dec 22, 2017

@snide Could you should what either option would look like in an actual hierarchy? So like the Parent is indeterminate because only some of the children are checked.

@uboness
Copy link
Contributor Author

uboness commented Dec 22, 2017

I figured it's OK to go with our own style here.

absolutely

as @cchaos mentioned, it would be great to see it as part of a bigger picture to have a solid feeling about it... but if I would need to choose now, i'd go for the diagonal version

@uboness
Copy link
Contributor Author

uboness commented Dec 22, 2017

another option... how about a dot in the middle? (like a little circle in the middle of the box)... it's sorta half full as well

@snide
Copy link
Contributor

snide commented Dec 22, 2017

@uboness don't want a dot, it will read as selected. Agree on the diagonal.

@snide
Copy link
Contributor

snide commented Dec 22, 2017

After some discussion on slack we decided this feature wasn't needed. Since our tables are often limitless, it's better to just say the equivalent of "Delete X things" in our buttons to designate partial selections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants