Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META] Data Grid near term roadmap #2504

Closed
2 of 3 tasks
snide opened this issue Oct 30, 2019 · 12 comments
Closed
2 of 3 tasks

[META] Data Grid near term roadmap #2504

snide opened this issue Oct 30, 2019 · 12 comments

Comments

@snide
Copy link
Contributor

snide commented Oct 30, 2019

The following are road map items for data grid listed in general order of roll out.

Work through existing priority bugs

✅ Define an initial width for columns, and a config for whether it can be resized #2621

Right now the columns are automatic on load and only change width as the user adjusts. We need a way to pass the initial width to the columns.

Provide a header column menu for performing actions on the column #2461

To aid in discoverability, we need to add a menu for sorting / hiding and any other actions you might want to pass onto a column. This should include the ability to add your own actions to the menu.

✅ Extra toolbar controls #2594

We need a prop for passing in additional toolbar buttons. Since this would be injected into the grid, this shouldn't require additional props to toolbarVisibility.

✅ Checkbox for rows #2846

We need the ability to add checkboxes to rows so that actions can be passed onto them. This should mirror our work in EuiBasicTable

✅ Expand row into its own flyout #2462

We need the ability to look at a detail view of row content. By default this should show the same data, just in a vertical format without truncation. Beyond that we should allow the content of the flyout to be a completely custom render.

@chandlerprall
Copy link
Contributor

@snide what do you want to see with

Datetime schema section and sorting

?

@snide
Copy link
Contributor Author

snide commented Dec 17, 2019

@snide what do you want to see with

Datetime schema section and sorting

?

I think it's too much to autodetect that schema given the variations, but I think a good minimum would be if the user lets us know it's a datetime field and it's passed in a common format (hand waavy let's start with ECS, ISO...etc) it could sort against it from newest/oldest...etc. Another helper might be to allow it to have a moment config that we can use to do the same.

I'm very handwavy on this. I know it's difficult. But mostly I think if we can't provide a default sort (right now it just fails) we probably shouldn't include it as one of our default "auto" schemas.

@mmourafiq
Copy link

A lot of great progress, thank you for providing such a nice abstraction and framework overall.

Is there any ETA for: Checkbox for rows.

@snide
Copy link
Contributor Author

snide commented Jan 22, 2020

A lot of great progress, thank you for providing such a nice abstraction and framework overall.

Is there any ETA for: Checkbox for rows.

We don't provide estimates beyond saying things like "near term". It's on our current roadmap, and is a heavily requested feature, so you can assume it will be coming in the near term 😄 .

@kertal
Copy link
Member

kertal commented Jan 24, 2020

There's another component, who's excited to be datagrid-dilated, it's the Data Table Vis. I've got a general question. In the old table, when you hovered a cell, you got the filter in & out icons. In the new grid when you've to click with the mouse when you're not using the keyboard. So there's one click more. Is this possible in the new grid, or is there something like this on the roadmap? muchas gracias!

Bildschirmfoto 2020-01-23 um 12 04 16

@snide
Copy link
Contributor Author

snide commented Jan 24, 2020

@kertal You can change the render of the the content into the cell (which can include links or buttons), and then you can disable the popover using isExpandable on EuiDataGridColumn.
Because Data Grid truncates content by default, you'll want to make sure any such interactive items are the first things in the render. Alternatively, you could create a column of actions if you needed.

@myasonik
Copy link
Contributor

I thought for cell level actions the recommendation was to go with adding the actions in the popover (as that's at least currently the plan for Discover's grid).

@kertal
Copy link
Member

kertal commented Jan 27, 2020

thx, I just wanted to talk about it, before establishing this different user interaction pattern around Kibana. CC: @AlonaNadler

@AlonaNadler
Copy link

I share the same concern @kertal raised. The need to hover on a field, select it, point the mouse to the little icon to filter a field too long/tedious : @snide filtering from a cell is very common, the need to get the mouse to the small icon is not ideal. Ideally, it will be good if we can solve it with either keeping the actions in the cell or opening a pop up while selecting the cell area. There might be other options.
The Tricky part with the popup is that we will soon gonna have drill downs who are planning to use the pop up (by clicking on a cell user might have multiple drill-downs actions). It might be good thinking how all these interactions work together.

@snide
Copy link
Contributor Author

snide commented Jan 27, 2020

Either style is supported by EUI and this isn't a data grid issue, but a Kibana design issue. Very specifically, data grid is not the Discover application, and the design decisions or defaults for the grid don't need to be the ones used in Discover. It just needs to provide flexibility for implementation.

This isn't the issue for this conversation. I'd start with a requirement list in Kibana of what you plan in Discover. For @kertal, the method I provided should be enough to replicate what was requested.

@kertal kertal closed this as completed Jan 28, 2020
@kertal kertal reopened this Jan 28, 2020
@kertal
Copy link
Member

kertal commented Jan 28, 2020

thx @snide, sorry for accidentally closing this, just started my first coffee in the morning, wouldn't happen after the 2nd ;)

@snide
Copy link
Contributor Author

snide commented Feb 19, 2020

I'm closing this issue now that all but one of the issues are addressed. 🎉

@snide snide closed this as completed Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants