Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataGrid should allow reordering columns without hiding #2622

Closed
myasonik opened this issue Dec 10, 2019 · 1 comment · Fixed by #2993
Closed

DataGrid should allow reordering columns without hiding #2622

myasonik opened this issue Dec 10, 2019 · 1 comment · Fixed by #2993

Comments

@myasonik
Copy link
Contributor

Currently, there's one popover that handles reordering columns and show/hiding them.

In Discover, showing and hiding columns is handled outside of the grid so I don't want duplicate controls for that but I do still want to allow users to reorder columns.

This also calls into question whether the popover trigger name should be "hide fields". It's not clear to a user wanting to reorder columns that this is where they should go look and it becomes really confusing if we simply allow disabling the ability to hide fields.

@myasonik
Copy link
Contributor Author

This is needed for Discover's DataGrid reimplementation (elastic/kibana#51531)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants