Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiBadge] Prevent color opacity #2883

Closed
thompsongl opened this issue Feb 19, 2020 · 6 comments
Closed

[EuiBadge] Prevent color opacity #2883

thompsongl opened this issue Feb 19, 2020 · 6 comments

Comments

@thompsongl
Copy link
Contributor

Per discussion in #2850, now that we've opened up EuiColorPicker to opacity we may want to do more than give console warnings for invalid color input. For instance, 8-digit hex values are still renderable by EuiBadge but are not desirable and can cause contrast failures.

#2804 is related for validation reasons

Solutions:

  • Set alpha channel to 1 regardless of provided color value
  • Render a transparent badge to show incompatibility
  • Update warning message to indicate opacity support
  • Take opacity into account in color contrast calculations (if possible)
@cchaos cchaos changed the title EuiBadge prevent color opacity [EuiBadge] Prevent color opacity Sep 20, 2020
@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

❌ We're automatically closing this issue due to lack of activity. Please comment if you feel this was done in error.

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@daveyholler daveyholler closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants