-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiProgress] Add option to render as a meter #2983
Comments
@myasonik please assign me this |
Based on discussion in #2986, there are more items to consider:
|
Just throwing in my two cents: If EUI is willing to support the semantic differences between If EUI would rather not know they exist, then I think it's ok to allow |
EuiProgress
as a <meter />
👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed. |
❌ Per our previous message, this issue is auto-closing after having been open and inactive for a year. If you strongly feel this is still a high-priority issue, or are interested in contributing, please leave a comment or open a new issue linking to this one for context. |
Summary
The semantics of
<progress />
and<meter />
are a little different though visually they present really similar info.In Discover (and probably other areas), Kibana uses
EuiProgress
to show a ratio of a thing, not to actually show a "progressing" state. In these cases,<meter />
would be the appropriate element to use.What to do
Add an option to render
EuiProgress
with a<meter />
element instead. This might require some CSS tweaks as well to make sure both components render the same in all browsers.Add a note to the docs about the difference and when to use which. (
<progress />
should be used when it is a long running task that will complete.<meter />
should be used when you are displaying a static ratio.)The text was updated successfully, but these errors were encountered: