Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiProgress] Add option to render as a meter #2983

Closed
myasonik opened this issue Mar 4, 2020 · 7 comments
Closed

[EuiProgress] Add option to render as a meter #2983

myasonik opened this issue Mar 4, 2020 · 7 comments

Comments

@myasonik
Copy link
Contributor

myasonik commented Mar 4, 2020

Summary

The semantics of <progress /> and <meter /> are a little different though visually they present really similar info.

In Discover (and probably other areas), Kibana uses EuiProgress to show a ratio of a thing, not to actually show a "progressing" state. In these cases, <meter /> would be the appropriate element to use.

What to do

  1. Add an option to render EuiProgress with a <meter /> element instead. This might require some CSS tweaks as well to make sure both components render the same in all browsers.

  2. Add a note to the docs about the difference and when to use which. (<progress /> should be used when it is a long running task that will complete. <meter /> should be used when you are displaying a static ratio.)

@anishagg17
Copy link
Contributor

@myasonik please assign me this

@thompsongl
Copy link
Contributor

Based on discussion in #2986, there are more items to consider:

  • IE11 support/feature detection for meter
  • meter vs. progress API differences
    • Create EuiMeter?
    • Refactor EuiProgress?

@myasonik
Copy link
Contributor Author

myasonik commented Mar 9, 2020

Just throwing in my two cents:

If EUI is willing to support the semantic differences between meter and progress, I think two components would be a great long term move.

If EUI would rather not know they exist, then I think it's ok to allow EuiProgress to just render meter sometimes and let the implementing developer worry about if it's used correctly or not.

@cchaos cchaos changed the title Add option to render EuiProgress as a <meter /> [EuiProgress] Add option to render as a meter Mar 18, 2020
@snide snide mentioned this issue Mar 9, 2021
41 tasks
@github-actions
Copy link

github-actions bot commented Sep 7, 2021

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

github-actions bot commented Mar 6, 2022

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed.

@github-actions
Copy link

❌ Per our previous message, this issue is auto-closing after having been open and inactive for a year. If you strongly feel this is still a high-priority issue, or are interested in contributing, please leave a comment or open a new issue linking to this one for context.

@cee-chen cee-chen closed this as not planned Won't fix, can't repro, duplicate, stale Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants