Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard against importing from outside of src into src #327

Closed
cjcenizal opened this issue Jan 19, 2018 · 1 comment
Closed

Guard against importing from outside of src into src #327

cjcenizal opened this issue Jan 19, 2018 · 1 comment
Labels
chore developer experience

Comments

@cjcenizal
Copy link
Contributor

Doing so results in bugs, e.g. #203.

We should guard against this in the future by using something like create-react-app's ModuleScopePlugin (docs).
@cchaos
Copy link
Contributor

cchaos commented Sep 18, 2020

I don't think this problem exists anymore after the conversion to TS that forces us to import directly from the component file itself.

@cchaos cchaos closed this as completed Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore developer experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@snide @cchaos @cjcenizal