-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EuiDataGrid: Add footer row #3400
Comments
So I understand the request. You're not looking for us to provide the calculation, you just want a prop to give you space to put something above the pagination, after the grid. I assume this should be fixed, like the pagination in constrained views? |
@snide yes, exactly. I didn’t think about scrolling yet but having it fixed makes sense to me. |
OK. I should be able to add this fairly quickly. |
Ok, started building this one out then started thinking about how we'd want to use this. Do you...
|
From the screenshot above, it kind of looks like both, doesn't it? A grid row for the totals and a empty area for the data export. |
It's not a strict requirement for the export button to stay in that position - I think it's more accidental in the current UI. |
Export would be fine using the additionally toolbar controls that the grid already provides. I'll need to think about the footer though since it needs to output in the grid. That'll likely push it into needing an engineer. |
At the very least it'll need a pass around element focus - mouse may Just Work, but keyboard nav won't |
Hey @flash1293. We had a quick breakout on this in our weekly. Unfortunately I misunderstood your original request. This one is going to need a real engineer 😄 With our current roadmap we're pretty focused on getting the Markdown editor out the door in 7.9. We can add this an an enhancement request for 7.10. If that's too late I'd suggest one of the following:
Let us know your timeline, and sorry for the back and forth on this one. I was hoping just passing a simple "fill something in at the bottom" prop would work, but it sounds like we need a special prop on the columns themselves, and then we'll need to do some accessibility work. As a note, also for @kertal, who I know is also thinking about grid stuff. If either of you have a breakout week, where you could pair with a design on this, and also the menu headers #3087, it would help us out. We don't want to be a blocker for your projects, but @chandlerprall is heads down on the editor this minor so we won't get back to grid till 7.10. |
Thanks for the context, @snide . The timeline is not decided yet, it will be in the next planning round (~2 weeks from now). I will keep this issue updated. |
The Kibana app team is currently rewriting the data table visualization with the data grid component (elastic/kibana#64444).
The data table features a slightly different styled "summary" row which is shown on each page in the bottom of the table (the "total column" of the screenshot below):
To leverage data grid for this visualization, a new property on
EuiDataGridColumn
similar todisplay
could be introduced (e.g.displayBottom
)The text was updated successfully, but these errors were encountered: