Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Props table custom interface links not working #3644

Closed
thompsongl opened this issue Jun 23, 2020 · 1 comment · Fixed by #4125
Closed

[Docs] Props table custom interface links not working #3644

thompsongl opened this issue Jun 23, 2020 · 1 comment · Fixed by #4125
Assignees
@elizabetdev
Labels
bug documentation Issues or PRs that only affect documentation - will not need changelog entries good first issue

Comments

@thompsongl
Copy link
Contributor

I’m noticing that some object hrefs aren’t working in the docs. Is this just me ?
For example, in https://elastic.github.io/eui/#/tabular-content/tables. if I click Sorting under Props, nothing happens
@thompsongl thompsongl added bug documentation Issues or PRs that only affect documentation - will not need changelog entries labels Jun 23, 2020
@cchaos
Copy link
Contributor

cchaos commented Sep 20, 2020

Now that we can use the !!props-loader syntax and import prop types directly, we should get rid of the manual props table in the table docs.

@elizabetdev elizabetdev self-assigned this Oct 8, 2020
@elizabetdev elizabetdev mentioned this issue Oct 8, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elizabetdev elizabetdev

Labels
bug documentation Issues or PRs that only affect documentation - will not need changelog entries good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Docs, EuiBasicTable] Recreating props tables with props loader elizabetdev/eui
3 participants
@cchaos @thompsongl @elizabetdev