-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiProgress] Add semantic structure to label and value #3678
Comments
Comments from @cchaos: I definitely see the benefit of using the Let's consider just making the elements customizable, or we'll need to create a higher component like EuiListGroup that will create the whole element structure. With the risk of this PR continually expanding greater, let's table this discussion and put it into an issue for follow up. |
Ah, yeah, you're right. I guess we only go to the
Yup, should be fine! |
👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
Not planned as the current implementation is acceptable. |
Pulling out an idea from PR #3218 into a follow up issue.
Trying to think of a way to join the label and value text so there's something more semantic tying them together rather than just proximity...
I'm thinking maybe a
<dl>
might work? A DOM structure like this maybe:If we introduced an extra prop for how to render the wrapping element, we could even extend this to better work with a whole list of these like in the demo. Something like:
Where as changes the wrapping
<dl>
of each<EuiProgress />
to a<div>
so that we can create one list of progress bars, instead of n lists. (Maybe as is too vague and broad given that<div>
is probably the only valid value, but just throwing out an idea.)The text was updated successfully, but these errors were encountered: