Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiBadge] Handle invalid color entry #3765

Closed
thompsongl opened this issue Jul 17, 2020 · 0 comments · Fixed by #4481
Closed

[EuiBadge] Handle invalid color entry #3765

thompsongl opened this issue Jul 17, 2020 · 0 comments · Fixed by #4481
Labels
bug good first issue

Comments

@thompsongl
Copy link
Contributor

Currently during color validation in EuiBadge, entries that are not valid chroma-js values will result in console errors (Uncaught Error: unknown format: #D) and will block rendering in the docs.

Invalid entries should be noted with console.warn but the exception should not have such adverse rendering effects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[EuiBadge] : Handle invalid color entry akashgp09/eui
2 participants
@cchaos @thompsongl