Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiBasicTable] onChange parameter type unable to be determined leads to any #4011

Closed
alvarezmelissa87 opened this issue Sep 4, 2020 · 0 comments · Fixed by #4125
Closed

Comments

@alvarezmelissa87
Copy link

When using EuiBasicTableProps<T>['onChange'] type - onChange type has multiple options

(criteria: Criteria<T>) => void; | (criteria: CriteriaWithPagination<T>) => void; | undefined

This prevents the onChange parameters from being typed correctly and is implicitly set to any which causes TypeScript to complain. Neither Criteria<T> or CriteriaWithPagination<T> are exported. onChange param has to be explicitly typed.

e.g.
const onTableChange: EuiBasicTableProps<TypeOfItem>['onChange'] = (param) => { ...
Param is incorrectly set as any.

@cchaos cchaos changed the title EuiBasicTableProps - onChange parameter type unable to be determined leads to any [EuiBasicTable] onChange parameter type unable to be determined leads to any Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants