Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svg files not available if EUI used externally #410

Closed
gingerwizard opened this issue Feb 15, 2018 · 2 comments
Closed

svg files not available if EUI used externally #410

gingerwizard opened this issue Feb 15, 2018 · 2 comments

Comments

@gingerwizard
Copy link

If consuming the EUI and importing the scss the following warnings are displayed re missing svg files:

WARNING in ./node_modules/css-loader!./node_modules/postcss-loader/lib!./node_modules/sass-loader/lib/loader.js!./app/index.scss
(Emitted value instead of an instance of Error) postcss-inline-svg: /opt/ama_survey_app/client/app/index.scss:1747:9: Can't load '/opt/ama_survey_app/client/src/components/icon/assets/check.svg'
 @ ./app/index.scss 4:14-161
 @ ./app/index.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 ./app/index.js

They can obviously be copied into a place as a workaround. Is there a recommendation we can provide to ensure these are identified at the correct location i.e. in node_modules?

@cchaos
Copy link
Contributor

cchaos commented Feb 20, 2018

I think this should be fixed in master #407 because we changed the way the checkboxes and radios are handles and we no longer reference images directly in our CSS. Though maybe there still needs to be a fix for future images in CSS files?

@snide
Copy link
Contributor

snide commented Mar 9, 2018

This part is fixed.

@snide snide closed this as completed Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants