You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently to use a (third party) icon it is only possible to use a string as the logo identifier:
<EuiIcontype='logoAWS'/>
This is error prone since the there's nothing preventing the dev making a spelling mistakes, or renaming an icon on the EUI side without updating the consumers.
To prevent these mistakes, catch changes and improve intellisense I suggest icons are consumed as constants:
<EuiIcontype={euiIcons.logoAws}/>
Afaict all that's needed is to export typeToPathMap:
👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.
Currently to use a (third party) icon it is only possible to use a string as the logo identifier:
This is error prone since the there's nothing preventing the dev making a spelling mistakes, or renaming an icon on the EUI side without updating the consumers.
To prevent these mistakes, catch changes and improve intellisense I suggest icons are consumed as constants:
Afaict all that's needed is to export
typeToPathMap
:eui/src/components/icon/icon.tsx
Lines 39 to 56 in e475ce5
The text was updated successfully, but these errors were encountered: