You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
EuiContextMenu right now is designed to render inside of a popover (but doesn't strictly need to be). With this, it relies on the consuming developer to put it in EuiPopover which can provide some flexibility in styling but also can provide some headache as demonstrated when we were improving our focus states.
It's not immediately apperent which props should go on the ContextMenu and which should go on the Popover. I think we can get the same flexibility we currently have just by allowing EuiContextMenu to take a popoverProps prop which will pass everything through while setting up a sensible default for consumers while also relieving some boilerplate from every usage.
The text was updated successfully, but these errors were encountered:
👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.
EuiContextMenu right now is designed to render inside of a popover (but doesn't strictly need to be). With this, it relies on the consuming developer to put it in EuiPopover which can provide some flexibility in styling but also can provide some headache as demonstrated when we were improving our focus states.
It's not immediately apperent which props should go on the ContextMenu and which should go on the Popover. I think we can get the same flexibility we currently have just by allowing EuiContextMenu to take a
popoverProps
prop which will pass everything through while setting up a sensible default for consumers while also relieving some boilerplate from every usage.The text was updated successfully, but these errors were encountered: