Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiContextMenu] Should render EuiPopover for you? #4884

Closed
myasonik opened this issue Jun 15, 2021 · 2 comments
Closed

[EuiContextMenu] Should render EuiPopover for you? #4884

myasonik opened this issue Jun 15, 2021 · 2 comments

Comments

@myasonik
Copy link
Contributor

EuiContextMenu right now is designed to render inside of a popover (but doesn't strictly need to be). With this, it relies on the consuming developer to put it in EuiPopover which can provide some flexibility in styling but also can provide some headache as demonstrated when we were improving our focus states.

It's not immediately apperent which props should go on the ContextMenu and which should go on the Popover. I think we can get the same flexibility we currently have just by allowing EuiContextMenu to take a popoverProps prop which will pass everything through while setting up a sensible default for consumers while also relieving some boilerplate from every usage.

@github-actions
Copy link

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@github-actions
Copy link

❌ We're automatically closing this issue due to lack of activity. Please comment if you feel this was done in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant