Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiCodeBlock] Virtualization doesn't calculate correctly long tokens that break into a new line #5159

Closed
miukimiu opened this issue Sep 9, 2021 · 1 comment · Fixed by #5379
Labels

Comments

@miukimiu
Copy link
Contributor

miukimiu commented Sep 9, 2021

Found this bug while doing a review for #4993.

When the virtualization is set to true and a very long token breaks into a new line the text gets overlapped. The second example uses isVirtualized:

Screenshot 2021-09-09 at 16 12 57

Here's a CodeSandbox with the issue: https://codesandbox.io/s/code-block-isvirtualized-issue-t6cvt?file=/index.js.

@thompsongl
Copy link
Contributor

Just noting that the resolution here was to prohibit virtualized rendering and line wrapping: #5379 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants