-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EuiStepsHorizontal tooltip #5621
Comments
It looks like that OS tooltip is coming from the |
This component has already undergone rigourous a11y testing which was done in this PR: #4135 The @AnnaKuhir Can you explain why you would need this removed? |
We are developing a web application that needs internationalization. The title attribute, as I understand it, is generated under the hood (that is, it takes the step number: "Step 1" (for example), then the title of the step: "Completed step 1" and, if we have already passed this step, adds "is completed" at the end "). As a result, we get "Step 1: Completed step 1 is completed". And if I can translate the title of the step into some language, then "Step 1" and "is completed" can't. |
Would providing i18n tokens for the title strings also solve your use case? |
These should already all have i18n tokens: https://github.com/elastic/eui/blob/main/src/components/steps/step_strings.tsx |
Whoops, totally missed that, thanks Caroline! @AnnaKuhir, you should be able to translate all text in the tooltip using your i18n library of choice. |
Thank you for the ping on this issue. After talking with Constance, Caroline and Dave, the original question seems well served by adding Long-term, it would be best if vendors built keyboard functionality to show
I'm also going to add an EUI backlog ticket for exploring swapping the browser |
@constancecchen @cchaos @1Copenut thanks for your help! |
Could you describe how you see the use of i18n tokens for title translation? Even if we use the useEuiI18n function, it still just returns a string to us, right? And I expect that I can somehow pass this string to the EuiStepsHorizontal component to overwrite the button title. But the title of the button is defined in the EuiStepsHorizontal component and depends only on the status, that is, I can hardly overwrite it in any way |
You can check out our I18n EuiContext example for how translating our processed tokens works at a very basic level. If you want to take a look at how using a larger library like |
👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment. |
❌ We're automatically closing this issue due to lack of activity. Please comment if you feel this was done in error. |
Is it possible for us to get rid of the tooltip when hovering over the step button? (attached screenshot)
Since I did not find a prop that could provide us with this
Thanks!
The text was updated successfully, but these errors were encountered: