You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Search Kibana's codebase for {euiComponent}- (case sensitive) to check for usage of modifier classes
[ ] If usage exists, consider converting to a data attribute so that consumers still have something to hook into
General
Output CSS matches the previous CSS (works as expected in all browsers)
Rendered className(s) read as expected in snapshots and browsers
[ ] Checked component playground
Unit tests
shouldRenderCustomStyles() test was added and passes with parent component and any nested childProps (e.g. tooltipProps)
Converted Enzyme to RTL
Sass/Emotion conversion process
Converted all global Sass vars/mixins to JS (e.g. $euiSize to euiTheme.size.base)
Removed or converted component-specific Sass vars/mixins to exported JS versions
Listed var~/mixin~ removals in changelog
[ ] Ran yarn compile-scss to update var/mixin JSON files
[ ] Simplified calc() to mathWithUnits if possible (if mixing different unit types, this may not be possible) - No usages
[ ] Added an @warn deprecation message within the global_styling/mixins/{component}.scss file
Removed component from src/components/index.scss
Deleted any src/amsterdam/overrides/{component}.scss files (styles within should have been converted to the baseline Emotion styles)
CSS tech debt
Wrapped all animations or transitions in euiCanAnimate
Used gap property to add margin between items if using flex
Converted side specific padding, margin, and position to -inline and -blocklogical properties (check inline styles as well as CSS)
DOM Cleanup
Did NOT remove any block/element classNames (e.g. euiComponent, euiComponent__child)
SEARCH KIBANA FIRST: Deleted any modifier classNames or maps if not being used in Kibana.
Kibana due diligence
See below checklist/details section
Extras/nice-to-have
[ ] Documentation pass:
Reduced specificity where possible (usually by reducing nesting and class name chaining) - NOTE: Made a moderate pass at this but overall did not completely attempt to remove nested selectors/!importants
[ ] Check for issues in the backlog that could be a quick fix for that component
[ ] Optional component/code cleanup: consider splitting up the component into multiple children if it's overly verbose or difficult to reason about
The text was updated successfully, but these errors were encountered:
👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed.
Kibana usage
{euiComponent}-
(case sensitive) to check for usage of modifier classes[ ] If usage exists, consider converting to adata
attribute so that consumers still have something to hook intoGeneral
className(s)
read as expected in snapshots and browsers[ ] Checked component playgroundUnit tests
shouldRenderCustomStyles()
test was added and passes with parent component and any nestedchildProps
(e.g.tooltipProps
)Sass/Emotion conversion process
$euiSize
toeuiTheme.size.base
)Removed orconverted component-specific Sass vars/mixins toexportedJS versions[ ] Ranyarn compile-scss
to update var/mixin JSON files[ ] Simplified- No usagescalc()
tomathWithUnits
if possible (if mixing different unit types, this may not be possible)[ ] Added an@warn
deprecation message within theglobal_styling/mixins/{component}.scss
filesrc/components/index.scss
src/amsterdam/overrides/{component}.scss
files (styles within should have been converted to the baseline Emotion styles)CSS tech debt
euiCanAnimate
gap
property to add margin between items if using flex-inline
and-block
logical properties (check inline styles as well as CSS)DOM Cleanup
euiComponent
,euiComponent__child
)Kibana due diligence
See below checklist/details section
Extras/nice-to-have
[ ] Documentation pass:[ ] Check for issues in the backlog that could be a quick fix for that component[ ] Optional component/code cleanup: consider splitting up the component into multiple children if it's overly verbose or difficult to reason aboutThe text was updated successfully, but these errors were encountered: