Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Emotion] EuiSideNav #6412

Closed
25 tasks done
Tracked by #5685 ...
daveyholler opened this issue Nov 18, 2022 · 1 comment · Fixed by #7521
Closed
25 tasks done
Tracked by #5685 ...

[Emotion] EuiSideNav #6412

daveyholler opened this issue Nov 18, 2022 · 1 comment · Fixed by #7521
Assignees
Labels
emotion task A task associated with a larger issue, wouldn't prioritize it independently

Comments

@daveyholler
Copy link
Contributor

daveyholler commented Nov 18, 2022

Acceptance criteria

  • All SCSS files have been removed from the component(s) directory
  • All SCSS overrides have been removed from the Amsterdam theme
  • [ ] Any dependent components are identified in a new issue
  • Changelog is updated
  • [ ] Breaking changes are identified and broadcast to consumers Noted in PR, but 'breaking' changes are not guaranteed APIs and are therefore not flagged as such

Checklists

Kibana usage

  • Search Kibana's codebase for {euiComponent}- (case sensitive) to check for usage of modifier classes
    • If usage exists, consider converting to a data attribute so that consumers still have something to hook into - No usages for removed modifiers

General

  • Output CSS matches the previous CSS (works as expected in all browsers)
  • Rendered className(s) read as expected in snapshots and browsers
  • [ ] Checked component playground - No playground

    NOTE: Class components wrapped in withEuiTheme need to pass true as the second argument to its propUtilityForPlayground in src-docs/src/views/{component}/playground.js


Unit tests

  • shouldRenderCustomStyles() test was added and passes with parent component and any nested childProps (e.g. tooltipProps)
  • [ ] Removed any mount()ed snapshots in favor of render() or a more specific assertion - None

Sass/Emotion conversion process

  • Converted all global Sass vars/mixins to JS (e.g. $euiSize to euiTheme.size.base)
  • Removed or converted component-specific Sass vars/mixins to exported JS versions React props
  • Listed var/mixin removals in changelog
  • [ ] Ran yarn compile-scss to update var/mixin JSON files
  • Simplified calc() to mathWithUnits if possible (if mixing different unit types, this may not be possible) - Not possible, percentage usage
  • [ ] Added an @warn deprecation message within the global_styling/mixins/{component}.scss file
  • Removed component from src/components/index.scss
  • Deleted any src/amsterdam/overrides/{component}.scss files (styles within should have been converted to the baseline Emotion styles)

CSS tech debt

  • Wrapped all animations or transitions in euiCanAnimate
  • Used gap property to add margin between items if using flex
  • Converted side specific padding, margin, and position to -inline and -block logical properties (check inline styles as well as CSS)

DOM Cleanup

  • Did NOT remove any block/element classNames (e.g. euiComponent, euiComponent__child)
  • SEARCH KIBANA FIRST: Deleted any modifier classNames or maps if not being used in Kibana.

Kibana due diligence

  • Pre-emptively check how your conversion will impact the next Kibana upgrade. This entails searching/grepping through Kibana (excluding **/target, **/*.snap, **/*.storyshot for less noise) for eui{Component} (case sensitive) to find:
  • Any test/query selectors that will need to be updated - None
  • Any Sass or CSS that will need to be updated, particularly if a component Sass var was deleted - Yes, usages of euiSideNavEmbellish mixin
  • Any direct className usages that will need to be refactored (e.g. someone calling the euiBadge class on a div instead of simply using the EuiBadge component) - None

Extras/nice-to-have

  • [ ] Documentation pass:
  • Reduced specificity where possible (usually by reducing nesting and class name chaining)
  • [ ] Check for issues in the backlog that could be a quick fix for that component
  • Optional component/code cleanup: consider splitting up the component into multiple children if it's overly verbose or difficult to reason about
@github-actions
Copy link

👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed.

@JasonStoltz JasonStoltz added task A task associated with a larger issue, wouldn't prioritize it independently and removed stale-issue labels May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emotion task A task associated with a larger issue, wouldn't prioritize it independently
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants