Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in the complementary palette #6901

Closed
markov00 opened this issue Jul 4, 2023 · 2 comments · Fixed by #6992
Closed

Typo in the complementary palette #6901

markov00 opened this issue Jul 4, 2023 · 2 comments · Fixed by #6992
Assignees
@breehall
Labels
bug low hanging fruit An issue, often a bug, that is lower effort and clearly ought to be fixed

Comments

@markov00
Copy link
Member

markov00 commented Jul 4, 2023

Describe the bug
There is a color palette, from blue to orange, wrongly called Complimentary - euiPaletteComplimentary that should instead be called euiPaletteComplementary due to the complementary nature of its color

Screenshots

Screenshot 2023-07-04 at 16 12 51
@markov00 markov00 added bug ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible labels Jul 4, 2023
@markov00 markov00 mentioned this issue Jul 4, 2023
Closed
@1Copenut 1Copenut added the low hanging fruit An issue, often a bug, that is lower effort and clearly ought to be fixed label Jul 5, 2023
@1Copenut
Copy link
Contributor

1Copenut commented Jul 5, 2023 •
edited
Loading

Thank you for the report @markov00. I'll give this a look this week. I'm able to reproduce the issue and see where it's coming from in the src/ directory. It'll be easy to fix, but could be a breaking change. Will keep an eye out for this as I work to remediate.

@1Copenut 1Copenut removed the ⚠️ needs validation For bugs that need confirmation as to whether they're reproducible label Jul 5, 2023
@cee-chen
Copy link
Contributor

Per Tomasz's suggestion, keep the old spelling with a @deprecated jsdoc comment

@cee-chen cee-chen assigned cee-chen and unassigned cee-chen Jul 10, 2023
@breehall breehall mentioned this issue Jul 25, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@breehall breehall

Labels
bug low hanging fruit An issue, often a bug, that is lower effort and clearly ought to be fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Color Palette] Deprecate euiPaletteComplimentary; Add euiPaletteComplementary breehall/eui
4 participants
@cee-chen @1Copenut @markov00 @breehall