-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add control columns to EuiDataGrid #2846
Add control columns to EuiDataGrid #2846
Conversation
I'll handle the design pass on this one today. |
Given that this exacerbates #2626, are we comfortable shipping this without a fix for that? |
I think it's a separate PR. |
I agree with Dave - probably best to keep that as a separate PR to keep the overall diff size down, and there's some extra questions&decisions to be had first which are separate from the control column stuff. |
OK @chandlerprall. I fixed the styling issues and cleaned up the docs example to be a little more polished. Some things I did:
As part of this I had to navigate your code a bit and found it easy enough to read. Only comment is that some of it's a little repetitive, but I prefer that to heavy abstraction since this component is already tricky enough. One feature request (only if easy). I'd prefer that we could pass arbitrary selectors onto the row itself. Similar to |
@snide Quick design question. This pattern with using the triple dot icon before a link is new and not really how we've used that icon before. Thoughts on why using that instead of our typical down arrow to the right of the link to indicate popovers? |
No good reason. This isn't baked into the component itself, just the docs. I started with the arrow, but then noticed we were using the dots on the right side so I figured I'd try it out. Likely a bad idea. I'll add the arrow back in. |
Thinking through this, and trying some ideas out. |
Added a flyout example to the docs, which effectively answers the needs of #2462 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; tested locally. One thing to look into if you want.
Summary
Fixes #2623
Adds control columns to
EuiDataGrid
for ancillary row interaction. Needs a design pass and tests.This strongly highlights the bug reported in #2626.
Checklist