-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiToolTip] Add display
prop
#4096
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
💚 CLA has been signed |
Welcome @Phizzard 👋 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also don't forget to check off or cross out items in the summary checklist. One additional thing you'll need to add is a changelog entry which you can find a link to in the checklist. Just be sure to follow the pattern in that file.
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Oh and we'll need an additional Jest test for this new prop which you can add in the associated |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4096/ |
Jenkins, test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, this isn't actually working because of the way the component renders.
Preview documentation changes for this PR: https://eui.elastic.co/pr_4096/ |
Jenkins, test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4096/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Phizzard for making those changes. One last thing is that it'd be great to see an example of this in the docs. Can you add one where it's using a <EuiButton fullWidth>
component as the children?
block: 'euiToolTipAnchor--displayBlock', | ||
}; | ||
|
||
export const DISPLAY = Object.keys(displayToClassNameMap); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't used anywhere, safe to remove.
export const DISPLAY = Object.keys(displayToClassNameMap); |
|
||
- Added `display` prop to `EuiTooltip` ([#4096](https://github.com/elastic/eui/pull/4096)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Added `display` prop to `EuiTooltip` ([#4096](https://github.com/elastic/eui/pull/4096)) | |
- Added `display` prop to `EuiTooltip` ([#4096](https://github.com/elastic/eui/pull/4096)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, it looks like you'll need to merge master to get the updated changelog file and move this to the newest master section.
Summary
This feature adds a
display
prop to the EuiTooltip component to be a means of quick customization for handling display values, instead of manually adding a class into the propanchorClassName
.A similar implementation of this exists in the EuiPopover component.
Checklist