Use go-shellquote to split rules into arguments #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rule implementation naively split rules using strings.Fields, but this did not handle arguments that were quoted in cases where the arguments themselves contain spaces. Now go-shellquote is used to split the arguments before parsing. Fixes elastic#114
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
andrewkroh
added
Team:Security-External Integrations
efd6
reviewed
Jul 7, 2022
efd6
approved these changes
Jul 13, 2022
renini
pushed a commit
to renini/go-libaudit
that referenced
this pull request
Jun 26, 2024
The rule implementation naively split rules using strings.Fields, but this did not handle arguments that were quoted in cases where the arguments themselves contain spaces. Now go-shellquote is used to split the arguments before parsing. Fixes elastic#114
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rule implementation naively split rules using strings.Fields, but this did not
handle arguments that were quoted in cases where the arguments themselves
contain spaces.
Now go-shellquote is used to split the arguments before parsing.
Fixes #114