Add opaque Payload property to AuditMessage #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aleksmaus
commented
May 23, 2024
aleksmaus
commented
- Add opaque Payload property to AuditMessage
- Replace deprecated ioutil
- Get rid of go.uber.org/multierr dependency
- Update go to 1.21
* Add opaque Payload property to AuditMessage * Replace deprecated ioutil * Get rid of go.uber.org/multierr dependency * Update go to 1.21
…ile on Mac vs Linux, so the test on Mac fails while works on Linux
efd6
reviewed
May 26, 2024
reassembler_test.go
Outdated
Comment on lines
108
to
113
| func testPayloadForMessage(msg *auparse.AuditMessage) map[string]interface{} { | ||
| return map[string]interface{}{ | ||
| "seq": msg.Sequence, | ||
| "typ": msg.RecordType, | ||
| } | ||
| } |
There was a problem hiding this comment.
Could you please elaborate what needs to be changed?
There was a problem hiding this comment.
Can you place the helper below the calling function in source order. We don't have C compiler constraints and context first makes code easier to comprehend.
There was a problem hiding this comment.
Moved after the calling function, gave it a better name.
This is for OTel, need to be able to attach the "context" to the messages, so can reconstruct the otel "scope" and "resources" attributes after "reassembly" |
efd6
approved these changes
May 28, 2024
andrewkroh
approved these changes
May 28, 2024
renini
pushed a commit
to renini/go-libaudit
that referenced
this pull request
Jun 26, 2024
* Add opaque Payload property to AuditMessage * Add opaque Payload property to AuditMessage * Replace deprecated ioutil * Get rid of go.uber.org/multierr dependency * Update go to 1.21 * Rollback the golden file check, apparently it creates the different file on Mac vs Linux, so the test on Mac fails while works on Linux * Address code review feedback
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.