From 87caa61ae1abac819bd22a9d1f9c85d9d95e30f4 Mon Sep 17 00:00:00 2001
From: DEBOJIT KAKOTI <debojkakoti88@gmail.com>
Date: Thu, 16 Jul 2020 15:04:55 +0530
Subject: [PATCH] [Kibana] Add loadbalancerIP to service spec in kibana (#726)

---
 kibana/templates/service.yaml |  3 +++
 kibana/tests/kibana_test.py   | 14 ++++++++++++++
 kibana/values.yaml            |  1 +
 3 files changed, 18 insertions(+)

diff --git a/kibana/templates/service.yaml b/kibana/templates/service.yaml
index 71400a88d..dfb254c0c 100644
--- a/kibana/templates/service.yaml
+++ b/kibana/templates/service.yaml
@@ -13,6 +13,9 @@ metadata:
 {{- end }}
 spec:
   type: {{ .Values.service.type }}
+{{- if .Values.service.loadBalancerIP }}
+  loadBalancerIP: {{ .Values.service.loadBalancerIP }}
+{{- end }}
 {{- with .Values.service.loadBalancerSourceRanges }}
   loadBalancerSourceRanges:
 {{ toYaml . | indent 4 }}
diff --git a/kibana/tests/kibana_test.py b/kibana/tests/kibana_test.py
index 1341c6146..38a9fb154 100644
--- a/kibana/tests/kibana_test.py
+++ b/kibana/tests/kibana_test.py
@@ -51,6 +51,9 @@ def test_defaults():
     # Make sure that the default 'loadBalancerSourceRanges' list is empty
     assert "loadBalancerSourceRanges" not in r["service"][name]["spec"]
 
+    # Make sure that the default 'loadBalancerIP' string is empty
+    assert "loadBalancerIP" not in r["service"][name]["spec"]
+
 
 def test_overriding_the_elasticsearch_hosts():
     config = """
@@ -615,3 +618,14 @@ def test_setting_fullnameOverride():
         ]
         == "kibana"
     )
+
+
+def test_adding_loadBalancerIP():
+    config = """
+    service:
+      loadBalancerIP: 12.5.11.79
+    """
+
+    r = helm_template(config)
+
+    assert r["service"][name]["spec"]["loadBalancerIP"] == "12.5.11.79"
diff --git a/kibana/values.yaml b/kibana/values.yaml
index 1987333da..c2742c6b4 100755
--- a/kibana/values.yaml
+++ b/kibana/values.yaml
@@ -95,6 +95,7 @@ updateStrategy:
 
 service:
   type: ClusterIP
+  loadBalancerIP: ""
   port: 5601
   nodePort: ""
   labels: {}