readinessProbe missing -k for curl

[davidishee]

Chart version:

Latest on master has the issue, but originally found on 7.16.3

https://github.com/elastic/helm-charts/blob/main/elasticsearch/templates/statefulset.yaml

a11730e

Kubernetes version:

v1.21.11+31d53a1

Kubernetes provider: E.g. GKE (Google Kubernetes Engine)

OpenShift

Helm Version:

3.3.4

helm get release output

e.g. helm get elasticsearch (replace elasticsearch with the name of your helm release)

Be careful to obfuscate every secrets (credentials, token, public IP, ...) that could be visible in the output before copy-pasting.

If you find some secrets in plain text in helm get release output you should use Kubernetes Secrets to managed them is a secure way (see Security Example).

Output of helm get release

Describe the bug:

Line 292 of the readinessProbe doesn't include -k so it fails if security is enabled.

https://github.com/elastic/helm-charts/blame/8565b30cde0c373bbd2812079c2114bfcf8ed524/elasticsearch/templates/statefulset.yaml#L292

Steps to reproduce:

1. Deploy chart with security enabled (https)
2. readiness probes fail

Expected behavior:

readiness probes succeed when security (https) is enabled.

Provide logs and/or server output (if relevant):

Be careful to obfuscate every secrets (credentials, token, public IP, ...) that could be visible in the output before copy-pasting

Readiness probe failed: Waiting for elasticsearch cluster to become ready (request params: "wait_for_status=green&timeout=1s" ) Cluster is not yet ready (request params: "wait_for_status=green&timeout=1s" )

Any additional context:

See #638 for changes that broke it.

[davidishee]

On further review, I think -k is being passed in correctly. My use-case is still failing, but due to some other reason.