Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose add_recourse_metadata option to k8s package #2362

Closed
ChrsMark opened this issue Dec 20, 2021 · 1 comment · Fixed by #2370
Closed

Expose add_recourse_metadata option to k8s package #2362

ChrsMark opened this issue Dec 20, 2021 · 1 comment · Fixed by #2370
Assignees
@tetianakravchenko
Labels
release-pending Team:Integrations Label for the Integrations team

Comments

@ChrsMark
Copy link
Member

At elastic/beats#29133 we added add_recourse_metadata option for k8s Metricbeat module. In Beats it is possible to disable this setting in case one do not want to add such metadata. In addition only labels are added by default while annotations not. It would be nice if we have an option to configure this setting from the k8s package too so as to provide full experience to our users.

cc: @tetianakravchenko @MichaelKatsoulis
@ChrsMark ChrsMark added Team:Integrations Label for the Integrations team release-pending labels Dec 20, 2021
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

@tetianakravchenko tetianakravchenko self-assigned this Dec 21, 2021
This was referenced Dec 22, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tetianakravchenko tetianakravchenko

Labels
release-pending Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose add_resource_metadata for container and pods resources tetianakravchenko/integrations
3 participants
@ChrsMark @elasticmachine @tetianakravchenko