Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of a new RabbitMQ timestamp format #2905

Closed
leweafan opened this issue Mar 23, 2022 · 6 comments
Closed

Add support of a new RabbitMQ timestamp format #2905

leweafan opened this issue Mar 23, 2022 · 6 comments
Assignees
Labels
Integration:rabbitmq RabbitMQ Logs and Metrics Stalled Team:Integrations Label for the Integrations team

Comments

@leweafan
Copy link

leweafan commented Mar 23, 2022

Describe the enhancement:

Add RabbitMQ timestamp format with nanosecond precision and timezone "2022-03-23 13:16:58.000369+03:00".
Latest version switched to new default timestamp format and it's not supported by filebeat rabbitmq module.
Previous timestamp format "2019-04-12 10:11:15.094".

Now RabbitMQ ingest pipeline using DATETIME pattern and it should be replaced by TIMESTAMP_ISO8601 (see these comments about this).

RabbitMQ logging description - https://www.rabbitmq.com/logging.html

Describe a specific use case for the enhancement or feature:

2022-03-23 13:16:58.000369+03:00 [warning] <0.24873.39> client unexpectedly closed TCP connection

This issue applies to the package integration and to the Filebeat module.

@mtojek mtojek added the Team:Integrations Label for the Integrations team label Mar 23, 2022
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

@jsoriano jsoriano transferred this issue from elastic/beats Mar 29, 2022
@jsoriano
Copy link
Member

Ping @elastic/obs-service-integrations.

@jsoriano
Copy link
Member

Updated description with reference to these comments elastic/beats#13879 (comment), and moved to the integrations repository as this applies to the package integration and to the Filebeat module.

@andrewkroh andrewkroh added the Integration:rabbitmq RabbitMQ Logs and Metrics label May 6, 2022
@JanKnipp
Copy link

I'm seeing the same issue with the agent integration for rabbitmq (which of course uses filebeat)

2022-11-24 07:37:06.753000+01:00 [error] <0.30307.23> vhost xxxx not found

this basically makes the log integration for rabbitmq "useless" as grok pattern matching will always fail.

the change is not too hard

[ { "set": { "field": "event.ingested", "value": "{{_ingest.timestamp}}" } }, { "set": { "field": "ecs.version", "value": "8.0.0" } }, { "set": { "field": "event.kind", "value": "event" } }, { "set": { "field": "event.type", "value": "info" } }, { "rename": { "field": "message", "target_field": "event.original", "ignore_missing": true } }, { "grok": { "field": "event.original", "patterns": [ "%{TIMESTAMP_ISO8601:timestamp} \\[%{WORD:log.level}\\] %{ERL_PID:rabbitmq.log.pid} %{GREEDYMULTILINE:message}" ], "pattern_definitions": { "GREEDYMULTILINE": "(.|\n)*", "ERL_PID": "\\<%{INT}+\\.%{INT}+\\.%{INT}+\\>" }, "ignore_missing": true } }, { "date": { "field": "timestamp", "formats": [ "yyyy-MM-dd HH:mm:ss.SSSSSSZZZZZ" ], "target_field": "@timestamp", "if": "ctx.event.timezone == null" } }, { "date": { "field": "timestamp", "formats": [ "yyyy-MM-dd HH:mm:ss.SSSSSSZZZZZ" ], "target_field": "@timestamp", "timezone": "{{ event.timezone }}", "if": "ctx.event.timezone != null" } }, { "remove": { "field": [ "timestamp" ] } }, { "remove": { "field": "event.original", "if": "ctx?.tags == null || !(ctx.tags.contains('preserve_original_event'))", "ignore_failure": true, "ignore_missing": true } }, { "pipeline": { "name": "logs-rabbitmq.log@custom", "ignore_missing_pipeline": true } } ]

@ritalwar
Copy link
Contributor

The change has been made to support new timestamp format.
Tested and is working fine.
PR link for integrations: #4918
PR link for filebeat: elastic/beats#34211

@botelastic
Copy link

botelastic bot commented Jan 25, 2024

Hi! We just realized that we haven't looked into this issue in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jan 25, 2024
@botelastic botelastic bot closed this as completed Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:rabbitmq RabbitMQ Logs and Metrics Stalled Team:Integrations Label for the Integrations team
Projects
None yet
Development

No branches or pull requests

7 participants