-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add saved object tags to integrations with Kibana saved objects #327
Comments
Mentioning @andresrc as he will drive the updates of integrations. I assume it means, any visualization / dashboard etc. where we will start using tags, will be only compatible with KB 7.11, means the package itself is probably only compatible with 7.11. No problem with that, just wanted to make sure compatibility is clear. |
@alexfrancoeur this is great news! +1 on automatically applying tags for the dashboards we ship with integrations. Thank you for starting this conversation ❤️ cc @sorantis @mukeshelastic from observability integrations |
As a quick update to this group, @pgayvallet has officially merged tags with out of the box support for dashboards and visualizations. We'll be discussing what additional improvements we can make for 7.11 (elastic/kibana#81980), but the functionality is now available. |
@andresrc We should start to create a guideline on how we use the tags inside the packages |
@jamiehynds and @epixa in the event we want to update any packages related to security. |
Tags added to maps with elastic/kibana#83197 |
Hey all, I wanted to provide a quick update around tags for 7.11. There has been some significant (and amazing) progress from @pgayvallet, @ryankeairns and team to support a global experience for tag usage. We now have search syntax to filter down results by This significantly increases discoverability and streamlines navigation of Kibana assets packaged with integrations. Have we come to a consensus on guidelines for integrations? If so, do we think that integrations will add support for tags in 7.11? I also believe that integrations are not bound by release, so maybe it's possible to iterate here. |
@mukeshelastic @sorantis @andresrc @mostlyjason @jamiehynds @ruflin @ph I'd love your perspective here. As you may recall, we asked the Kibana team to prioritize tags, so we have a mechanism to organize assets we are installing with modules and integrations. Do we already have a plan in place to leverage them? I know it's been discussed, but not sure where we ended up. |
My suggestion is we start simple with 2 tags:
|
We discussed the possibility to use tags as a mechanism to automatically expose integrations' assets in the UI. For example we could automatically add a link to a dashboard based on a tag matching service/integration name on a host's or container's details page. This actually aligns with @ruflin's first suggestion. |
@ruflin what you are proposing is to thave theses tags hardcoded at install time? The second steps would be to allow dev author to define more tags? |
Not sure what you mean by hardcoded. EPM would take the package name, create a tag out of it and add it to all assets. In addition, it adds the For your second part about devs adding tags: I'm wondering if a tag references the saved objects or if a tag is part of each saved object. If it part of each object, I guess it could already be used today? @alexfrancoeur might know more here. |
The reference is from the saved object referencing the tag to the tag SO |
Yes this exactly what I wanted to hear, this really make it simple. @pgayvallet so this is a N:N relationship and not denormalized. In that case maybe it's not a good idea to allow integration author to add tags, I would be worried about tag explosion. But maybe something that @masci can investigate? |
Pinging @elastic/integrations (Team:Integrations) |
Apologies to keep pinging on this one, but do we have a sense of target release or priority to start supporting tags with integrations? I see this was moved to backlog and do not see any PR's linked. One of the initial drivers to introduce this feature was to organize Kibana assets in packages. It feels like the technical implementation is relatively simple, it's just a matter of defining and agreeing upon a process. There is potentially still an opportunity to release alongside 7.11. |
@alexfrancoeur this is in the backlog as it still needs to be scheduled, we won't deliver anything in 7.11. As this will be a cross-team effort also on our side, I'll outline the proposed changes (most likely what ruflin said) along with an action plan during 7.12. |
Awesome, thank you so much for the update @masci ! |
We discussed the issue and my team recommendation is to start by letting EPM add the |
@mukeshelastic @alvarolobato FYI ^^ |
@masci does this mean we wouldn't be adding a tag with the package name or some way to identify the integration? |
@alvarolobato on a second read, the example in my comment might have been misleading. The idea is to start by letting EPM add tags automatically based on whatever informations the EPM itself has at install time: We are totally on board with the idea you described in the comment but what we propose not to do during this first phase is having developers adding tags before we know exactly how these tags would be used in the UI, a formal naming convention to avoid duplicates or similar variations of the same tag, and ultimately a better idea of how the granularity concept will affect a package containing multiple integrations. So the plan would be:
@exekias please correct me if I'm wrong |
That makes sense to me, thanks for clarifying Massi.
…On Sun, Mar 28, 2021, 14:36 Massimiliano Pippi ***@***.***> wrote:
@alvarolobato <https://github.com/alvarolobato> on a second read, the
example in my comment might have been misleading.
The idea is to start by letting EPM add tags automatically based on
whatever informations the EPM itself has at install time: managed is an
example but also the name of the package is a good candidate for automatic
tagging.
We are totally on board with the idea you described in the comment but
what we propose *not* to do during this first phase is having developers
adding tags before we know exactly how these tags would be used in the UI,
a formal naming convention to avoid duplicates or similar variations of the
same tag, and ultimately a better idea of how the granularity concept will
affect a package containing multiple integrations.
So the plan would be:
- phase one: only automatic tags added at install time
- phase two: integrations developers add tags beforehand, within the
package
@exekias <https://github.com/exekias> please correct me if I'm wrong
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#327 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEC42BHK5OVQLL3XYEHCNT3TF4WG5ANCNFSM4SY3V2ZQ>
.
|
++ let's make sure we get the Integration name automatically in, that will give us a lot already |
+1 to adding tag representing integration name when user installs integration. This will allow users to filter dashboards by integration name as well solutions - metrics or APM provide option to surface links to dashboards with appropriate filters. |
@masci for packages we're also maintaining a list of categories. Is this something we can also consider in phase one? |
@sorantis that would imply we add the info in the package manually - while that is a good example of a formal label we'll certainly add in the future, I'd wait for the granularity example (specifically, AWS) to be ready before going through the packages we have and add the label. |
A few notes about a few things that should be considered when implementing this:
|
@masci Do you think this will still make 7.16 on the integrations side? We have a PR ready on the Kibana side but we haven't yet added this to the package-spec. elastic/kibana#114110 |
Regarding the spec changes, we have added it recently as we exported dashboard with a tag: spec code |
Hey all, I wanted to follow up on this. Did we end up getting tags as part of the integrations package in 7.last? I couldn't find any linked issues |
I've opened an issue to add a standard set of tags to all Saved Objects installed by Fleet: elastic/kibana#123904 |
@jen-huang I think this can be closed now. Correct? |
Yep, done with elastic/kibana#123904 in 8.4. |
The Kibana team (well, @pgayvallet 😉) has a PR for saved object tagging targeted for 7.11 that is currently under review (elastic/kibana#79096). This is the MVP and we plan to iterate. That being said, I think there is an opportunity to update any packages with Kibana saved object tags in the same release. I realize the registry is not release based, but it'd be a nice announcement to go along with user generated tags 😄
Next up that's related to this effort, I plan to start up discussions with the team on elastic/kibana#70461
cc: @ruflin @mostlyjason @tbragin @kobelb @joshdover
The text was updated successfully, but these errors were encountered: