Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate apache integration #370

Closed
12 of 16 tasks
andresrc opened this issue Oct 30, 2020 · 8 comments
Closed
12 of 16 tasks

Migrate apache integration #370

andresrc opened this issue Oct 30, 2020 · 8 comments
Assignees
Labels
fleet-migration Used to track the migration to the new experience

Comments

@andresrc
Copy link
Collaborator

andresrc commented Oct 30, 2020

Package / Dataset creation or update checklist

This checklist is intended for Devs which create or update a package to make sure they are consistent.

If the change targets a specific ES / Kibana / Agent version, uncomment this line and specify version.

  • Required Kibana version set to target version: 7.11.0 We don't need to require Kibana 7.11.0 for this package.

All Changes

  • Change follows development guidelines
  • Supported versions of the subject being monitored are documented
  • Supported operating systems are documented (if applicable)
  • System tests exist
  • Documentation
  • Fields follow ECS and naming conventions
  • At least a manual test with ES / Kibana / Agent has been performed. (covered by system tests)
  • The required Kibana version is set to the lowest version used in the manual test.

Dashboards

  • Dashboards exists (if applicable)
  • Screenshots of added / updated dashboards
  • Datastream filters added to visualizations

Log datasets

  • Pipeline tests exist (if applicable)
  • Generated output for at least 1 log file exists

Metric datasets

This entry is currently recommended. It will be mandatory once we provide better support for it.

  • Sample event (sample_event.json) exists

New Packages

  • Screenshot of the Fleet "Add Integration" Page.
@andresrc andresrc added integration Label used for meta issues tracking each integration Team:Services labels Oct 30, 2020
@elasticmachine
Copy link

Pinging @elastic/integrations-services (Team:Services)

@mtojek mtojek self-assigned this Nov 17, 2020
@mtojek
Copy link
Contributor

mtojek commented Nov 19, 2020

@andresrc I'm not sure if I understand these action items:

Pipeline tests exist (if applicable)
Test log files exist for the grok patterns
Generated output for at least 1 log file exists

Pipeline tests use log files as test input. Once they're processed by ingest pipelines, the result is compared with generated output. I mean, pipeline tests require test log files and generated output, there is no way for them to exist without any of them.

Did you think about sth else?

EDIT:

It looks like it was missed in the PR review: #342 (comment)

@mtojek
Copy link
Contributor

mtojek commented Nov 24, 2020

As discussed offline with the team I will try to introduce a condition which will change the Metricbeat's behavior and emit adjusted fields under different names.

@mtojek
Copy link
Contributor

mtojek commented Nov 25, 2020

Let's write down all action item in a convenient order:

(once Docker images for fleet are released, dashboards may stop working)

@andresrc
Copy link
Collaborator Author

sorry, I'll remove the grok one, thanks!

@mtojek
Copy link
Contributor

mtojek commented Dec 1, 2020

Changes partially merged, I will proceed with the next step:

Modify Metricbeat to collect modified fields if running in Fleet mode

@mtojek
Copy link
Contributor

mtojek commented Dec 14, 2020

It looks like there were issues in the unified release, which blocked releasing changes in Metricbeat. It will block:

Fix metrics dashboard to properly visualize total_bytes

@mtojek
Copy link
Contributor

mtojek commented Dec 15, 2020

All action items done. Resolving.

@mtojek mtojek closed this as completed Dec 15, 2020
@masci masci added fleet-migration Used to track the migration to the new experience and removed integration Label used for meta issues tracking each integration labels Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fleet-migration Used to track the migration to the new experience
Projects
None yet
Development

No branches or pull requests

4 participants