From d790a05504d91e1bcb14e8c84b710e431a679f87 Mon Sep 17 00:00:00 2001 From: Linu Elias Date: Wed, 28 Aug 2024 18:38:24 +0530 Subject: [PATCH 1/4] doc-mssql --- packages/microsoft_sqlserver/_dev/build/docs/README.md | 5 ++--- packages/microsoft_sqlserver/changelog.yml | 5 +++++ packages/microsoft_sqlserver/docs/README.md | 5 ++--- packages/microsoft_sqlserver/manifest.yml | 2 +- 4 files changed, 10 insertions(+), 7 deletions(-) diff --git a/packages/microsoft_sqlserver/_dev/build/docs/README.md b/packages/microsoft_sqlserver/_dev/build/docs/README.md index 481ff82d07f..28dd4089b02 100644 --- a/packages/microsoft_sqlserver/_dev/build/docs/README.md +++ b/packages/microsoft_sqlserver/_dev/build/docs/README.md @@ -112,8 +112,7 @@ Read more in [instructions about each performance counter metrics](https://docs. #### Transaction log metrics -Collects system level `transaction_log` metrics information for SQL Server instance. -Metrics for user-level databases can be collected by providing a list of user databases for which metrics are to be collected. +By default, the system-level database `transaction_log` metrics for SQL Server instances are collected. Metrics for user-level databases can be collected either by specifying a list of user databases or, alternatively, by enabling the `Fetch from all databases` toggle to collect metrics from all databases on the server. Read more in [instructions and the operations supported by transaction log](https://docs.microsoft.com/en-us/sql/relational-databases/logs/the-transaction-log-sql-server?view=sql-server-ver15). @@ -167,7 +166,7 @@ Please refer to the following [document](https://www.elastic.co/guide/en/ecs/cur ### transaction_log -The Microsoft SQL Server `transaction_log` dataset provides metrics from the log space usage and log stats tables of the system databases. All `transaction_log` metrics will be available in the `sqlserver.metrics` field group. +The Microsoft SQL Server `transaction_log` dataset provides metrics from the log space usage and log stats tables. All `transaction_log` metrics will be available in the `sqlserver.metrics` field group. {{event "transaction_log"}} diff --git a/packages/microsoft_sqlserver/changelog.yml b/packages/microsoft_sqlserver/changelog.yml index 37d6e34c045..ee58b633aa5 100644 --- a/packages/microsoft_sqlserver/changelog.yml +++ b/packages/microsoft_sqlserver/changelog.yml @@ -1,4 +1,9 @@ # newer versions go on top +- version: "2.9.2" + changes: + - description: Update documentation for `transaction_logs` to include `Fetch from all databases` feature. + type: bugfix + link: https://github.com/elastic/integrations/pull/10915 - version: "2.9.1" changes: - description: Convert error.code to string diff --git a/packages/microsoft_sqlserver/docs/README.md b/packages/microsoft_sqlserver/docs/README.md index 2ebf8ee4134..cfab4f60739 100644 --- a/packages/microsoft_sqlserver/docs/README.md +++ b/packages/microsoft_sqlserver/docs/README.md @@ -112,8 +112,7 @@ Read more in [instructions about each performance counter metrics](https://docs. #### Transaction log metrics -Collects system level `transaction_log` metrics information for SQL Server instance. -Metrics for user-level databases can be collected by providing a list of user databases for which metrics are to be collected. +By default, the system-level database `transaction_log` metrics for SQL Server instances are collected. Metrics for user-level databases can be collected either by specifying a list of user databases or, alternatively, by enabling the `Fetch from all databases` toggle to collect metrics from all databases on the server. Read more in [instructions and the operations supported by transaction log](https://docs.microsoft.com/en-us/sql/relational-databases/logs/the-transaction-log-sql-server?view=sql-server-ver15). @@ -481,7 +480,7 @@ Please refer to the following [document](https://www.elastic.co/guide/en/ecs/cur ### transaction_log -The Microsoft SQL Server `transaction_log` dataset provides metrics from the log space usage and log stats tables of the system databases. All `transaction_log` metrics will be available in the `sqlserver.metrics` field group. +The Microsoft SQL Server `transaction_log` dataset provides metrics from the log space usage and log stats tables. All `transaction_log` metrics will be available in the `sqlserver.metrics` field group. An example event for `transaction_log` looks as following: diff --git a/packages/microsoft_sqlserver/manifest.yml b/packages/microsoft_sqlserver/manifest.yml index 2b785d22bfe..186b4f5391d 100644 --- a/packages/microsoft_sqlserver/manifest.yml +++ b/packages/microsoft_sqlserver/manifest.yml @@ -1,7 +1,7 @@ format_version: "3.0.2" name: microsoft_sqlserver title: "Microsoft SQL Server" -version: "2.9.1" +version: "2.9.2" description: Collect events from Microsoft SQL Server with Elastic Agent type: integration categories: From c07a3c072396028e77f8bf8737105bf70800bd74 Mon Sep 17 00:00:00 2001 From: Linu-Elias Date: Thu, 29 Aug 2024 10:42:55 +0530 Subject: [PATCH 2/4] Update packages/microsoft_sqlserver/_dev/build/docs/README.md Co-authored-by: subham sarkar --- packages/microsoft_sqlserver/_dev/build/docs/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/microsoft_sqlserver/_dev/build/docs/README.md b/packages/microsoft_sqlserver/_dev/build/docs/README.md index 28dd4089b02..3f1223374d5 100644 --- a/packages/microsoft_sqlserver/_dev/build/docs/README.md +++ b/packages/microsoft_sqlserver/_dev/build/docs/README.md @@ -112,7 +112,7 @@ Read more in [instructions about each performance counter metrics](https://docs. #### Transaction log metrics -By default, the system-level database `transaction_log` metrics for SQL Server instances are collected. Metrics for user-level databases can be collected either by specifying a list of user databases or, alternatively, by enabling the `Fetch from all databases` toggle to collect metrics from all databases on the server. +The system-level database `transaction_log` metrics for SQL Server instances are collected by default. Metrics for user-level databases can be collected by specifying a list of user databases or by enabling the `Fetch from all databases` toggle to collect metrics from all databases on the server. Read more in [instructions and the operations supported by transaction log](https://docs.microsoft.com/en-us/sql/relational-databases/logs/the-transaction-log-sql-server?view=sql-server-ver15). From 74a17b094afc0a7d7e1214358586a71ac54b0613 Mon Sep 17 00:00:00 2001 From: Linu-Elias Date: Thu, 29 Aug 2024 10:43:08 +0530 Subject: [PATCH 3/4] Update packages/microsoft_sqlserver/changelog.yml Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com> --- packages/microsoft_sqlserver/changelog.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/microsoft_sqlserver/changelog.yml b/packages/microsoft_sqlserver/changelog.yml index ee58b633aa5..222413df75c 100644 --- a/packages/microsoft_sqlserver/changelog.yml +++ b/packages/microsoft_sqlserver/changelog.yml @@ -1,7 +1,7 @@ # newer versions go on top - version: "2.9.2" changes: - - description: Update documentation for `transaction_logs` to include `Fetch from all databases` feature. + - description: Fix documentation for `transaction_logs` on default and custom database metrics. type: bugfix link: https://github.com/elastic/integrations/pull/10915 - version: "2.9.1" From 3a450ab4c9c3458503ea3000f396000504a10570 Mon Sep 17 00:00:00 2001 From: Linu Elias Date: Thu, 29 Aug 2024 10:45:34 +0530 Subject: [PATCH 4/4] resolve comments --- packages/microsoft_sqlserver/docs/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/microsoft_sqlserver/docs/README.md b/packages/microsoft_sqlserver/docs/README.md index cfab4f60739..8bf6f8d90d1 100644 --- a/packages/microsoft_sqlserver/docs/README.md +++ b/packages/microsoft_sqlserver/docs/README.md @@ -112,7 +112,7 @@ Read more in [instructions about each performance counter metrics](https://docs. #### Transaction log metrics -By default, the system-level database `transaction_log` metrics for SQL Server instances are collected. Metrics for user-level databases can be collected either by specifying a list of user databases or, alternatively, by enabling the `Fetch from all databases` toggle to collect metrics from all databases on the server. +The system-level database `transaction_log` metrics for SQL Server instances are collected by default. Metrics for user-level databases can be collected by specifying a list of user databases or by enabling the `Fetch from all databases` toggle to collect metrics from all databases on the server. Read more in [instructions and the operations supported by transaction log](https://docs.microsoft.com/en-us/sql/relational-databases/logs/the-transaction-log-sql-server?view=sql-server-ver15).