Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[D4C] change resource.label and resource.annotation to keyword type #5902

Merged
merged 2 commits into from
Apr 18, 2023
Merged

[D4C] change resource.label and resource.annotation to keyword type #5902

merged 2 commits into from
Apr 18, 2023

Conversation

mitodrummer
Copy link
Contributor

What does this PR do?

Changes the type for orchestrator.resource.label and orchestrator.resource.annotation to type keyword. "flattened" type has too many limitations for our use cases. Also added (BETA) to the integration description in the manifest.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@mitodrummer mitodrummer added the enhancement New feature or request label Apr 17, 2023
@mitodrummer mitodrummer requested review from a team and norrietaylor April 17, 2023 23:10
@elasticmachine
Copy link

elasticmachine commented Apr 17, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-18T00:07:04.995+0000

  • Duration: 15 min 32 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 26.667% (4/15) 👎 -64.859
Lines 100.0% (0/0) 💚 9.201
Conditionals 100.0% (0/0) 💚

@mitodrummer mitodrummer requested a review from mmat11 April 18, 2023 00:06
@mitodrummer mitodrummer merged commit 1e5bb84 into main Apr 18, 2023
@elasticmachine
Copy link

Package cloud_defend - 1.0.4 containing this change is available at https://epr.elastic.co/search?package=cloud_defend

bhapas pushed a commit to bhapas/integrations that referenced this pull request Apr 19, 2023
@mitodrummer @bhapas
[D4C] change resource.label and resource.annotation to keyword type (e…
5135ea5 
…lastic#5902)

* change resource.label and resource.annotation to keyword type

* pr link updated
@andrewkroh andrewkroh added the Integration:cloud_defend Defend for Containers label Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norrietaylor norrietaylor norrietaylor approved these changes

@mmat11 mmat11 Awaiting requested review from mmat11

Assignees
No one assigned
Labels
enhancement New feature or request Integration:cloud_defend Defend for Containers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mitodrummer @elasticmachine @norrietaylor @andrewkroh