Merge branch 'master' into apm-59784-serviceMapEnabled-config-default…

…-true

.eslintrc.js

@@ -49,6 +49,11 @@ const ELASTIC_LICENSE_HEADER = `
  */
 `;
 
+const allMochaRulesOff = {};
+Object.keys(require('eslint-plugin-mocha').rules).forEach(k => {
+  allMochaRulesOff['mocha/' + k] = 'off';
+});
+
 module.exports = {
   root: true,
 
@@ -137,7 +142,7 @@ module.exports = {
       },
     },
     {
-      files: ['x-pack/legacy/plugins/ml/**/*.{js,ts,tsx}'],
+      files: ['x-pack/plugins/ml/**/*.{js,ts,tsx}'],
       rules: {
         'react-hooks/exhaustive-deps': 'off',
       },
@@ -519,9 +524,7 @@ module.exports = {
      */
     {
       files: ['test/harden/*.js'],
-      rules: {
-        'mocha/handle-done-callback': 'off', // TODO: Find a way to disable all mocha rules
-      },
+      rules: allMochaRulesOff,
     },
 
     /**

.github/CODEOWNERS

@@ -26,7 +26,7 @@
 /src/plugins/kibana_legacy/ @elastic/kibana-app
 /src/plugins/timelion/ @elastic/kibana-app
 /src/plugins/dev_tools/ @elastic/kibana-app
-/src/plugins/dashboard_embeddable_container/ @elastic/kibana-app
+/src/plugins/dashboard/ @elastic/kibana-app
 
 # App Architecture
 /packages/kbn-interpreter/ @elastic/kibana-app-arch
@@ -88,7 +88,6 @@
 /x-pack/test/functional/services/ml.ts  @elastic/ml-ui
 # ML team owns the transform plugin, ES team added here for visibility
 # because the plugin lives in Kibana's Elasticsearch management section.
-/x-pack/legacy/plugins/transform/  @elastic/ml-ui @elastic/es-ui
 /x-pack/plugins/transform/  @elastic/ml-ui @elastic/es-ui
 /x-pack/test/functional/apps/transform/ @elastic/ml-ui
 /x-pack/test/functional/services/transform_ui/ @elastic/ml-ui
@@ -133,7 +132,7 @@
 /src/legacy/server/saved_objects/  @elastic/kibana-platform
 /src/legacy/server/status/ @elastic/kibana-platform
 /src/plugins/status_page/ @elastic/kibana-platform
-/src/dev/run_check_core_api_changes.ts @elastic/kibana-platform
+/src/dev/run_check_published_api_changes.ts @elastic/kibana-platform
 
 # Security
 /src/core/server/csp/  @elastic/kibana-security @elastic/kibana-platform

.github/ISSUE_TEMPLATE/v8_breaking_change.md

@@ -0,0 +1,36 @@
+---
+name: 8.0 Breaking change
+about: Breaking changes from 7.x -> 8.0
+title: "[Breaking change]"
+labels: Team:Elasticsearch UI, Feature:Upgrade Assistant
+assignees: ''
+
+---
+
+## Change description
+
+**Which release will ship the breaking change?**
+
+<!-- e.g., v7.6.2 -->
+
+**Describe the change. How will it manifest to users?**
+
+**What percentage of users will be affected?**
+
+<!-- e.g., Roughly 75% will need to make changes to x. -->
+
+**What can users to do to address the change manually?**
+
+<!-- If applicable, describe the manual workaround -->
+
+**How could we make migration easier with the Upgrade Assistant?**
+
+**Are there any edge cases?**
+
+## Test Data
+
+Provide test data. We can’t build a solution without data to test it against.
+
+## Cross links
+
+Cross-link to relevant [Elasticsearch breaking changes](https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-8.0.html).

.i18nrc.json

@@ -3,7 +3,7 @@
     "common.ui": "src/legacy/ui",
     "console": "src/plugins/console",
     "core": "src/core",
-    "dashboardEmbeddableContainer": "src/plugins/dashboard_embeddable_container",
+    "dashboard": "src/plugins/dashboard",
     "data": [
       "src/legacy/core_plugins/data",
       "src/plugins/data"

CONTRIBUTING.md

@@ -171,6 +171,8 @@ Bootstrap Kibana and install all the dependencies
 yarn kbn bootstrap
 ```
 
+> Node.js native modules could be in use and node-gyp is the tool used to build them. There are tools you need to install per platform and python versions you need to be using. Please see https://github.com/nodejs/node-gyp#installation and follow the guide according your platform.
+
 (You can also run `yarn kbn` to see the other available commands. For more info about this tool, see https://github.com/elastic/kibana/tree/master/packages/kbn-pm.)
 
 When switching branches which use different versions of npm packages you may need to run;

Jenkinsfile

@@ -3,7 +3,7 @@
 library 'kibana-pipeline-library'
 kibanaLibrary.load()
 
-kibanaPipeline(timeoutMinutes: 135) {
+kibanaPipeline(timeoutMinutes: 135, checkPrChanges: true) {
   githubPr.withDefaultPrComments {
     catchError {
       retryable.enable()

docs/apm/advanced-queries.asciidoc

@@ -21,22 +21,22 @@ TIP: Read the {kibana-ref}/kuery-query.html[Kibana Query Language Enhancements]
 
 [float]
 [[discover-advanced-queries]]
-=== Querying in the Discover app
+=== Querying in Discover
 
-It may also be helpful to view your APM data in the {kibana-ref}/discover.html[Discover app].
-Querying documents in Discover works the same way as querying in the APM app,
-and all of the example APM app queries can also be used in the Discover app.
+It may also be helpful to view your APM data in {kibana-ref}/discover.html[*Discover*].
+Querying documents in *Discover* works the same way as querying in the APM app,
+and all of the example APM app queries can also be used in *Discover*.
 
 [float]
-==== Example Discover app query
+==== Example Discover query
 
-One example where you may want to make use of the Discover app,
+One example where you may want to make use of *Discover*,
 is for viewing  _all_ transactions for an endpoint, instead of just a sample.
 
 TIP: Starting in v7.6, you can view 10 samples per bucket in the APM app, instead of just one.
 
 Use the APM app to find a transaction name and time bucket that you're interested in learning more about.
-Then, switch to the Discover app and make a search:
+Then, switch to *Discover* and make a search:
 
 ["source","sh"]
 -----