perf improvements

elastic · Feb 25, 2020 · 156a558 · 156a558
1 parent 9eb57e6
commit 156a558
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 15 deletions.
diff --git a/...bana/public/discover/np_ready/components/discover_grid/create_discover_grid_directive.tsx b/...bana/public/discover/np_ready/components/discover_grid/create_discover_grid_directive.tsx
@@ -20,5 +20,19 @@ import { wrapInI18nContext } from '../../../kibana_services';
 import { DiscoverGrid } from './discover_grid';
 
 export function createDiscoverGridDirective(reactDirective: any) {
-  return reactDirective(wrapInI18nContext(DiscoverGrid));
+  return reactDirective(wrapInI18nContext(DiscoverGrid), [
+    ['columns', { watchDepth: 'collection' }],
+    ['rows', { watchDepth: 'collection' }],
+    ['indexPattern', { watchDepth: 'reference' }],
+    ['sort', { watchDepth: 'value' }],
+    ['sampleSize', { watchDepth: 'reference' }],
+    ['searchDescription', { watchDepth: 'reference' }],
+    ['searchTitle', { watchDepth: 'reference' }],
+    ['useShortDots', { watchDepth: 'value' }],
+    ['onFilter', { watchDepth: 'reference', wrapApply: false }],
+    ['onRemoveColumn', { watchDepth: 'reference', wrapApply: false }],
+    ['onAddColumn', { watchDepth: 'reference', wrapApply: false }],
+    ['getContextAppHref', { watchDepth: 'reference', wrapApply: false }],
+    ['onSort', { watchDepth: 'reference', wrapApply: false }],
+  ]);
 }
diff --git a/...y/core_plugins/kibana/public/discover/np_ready/components/discover_grid/discover_grid.tsx b/...y/core_plugins/kibana/public/discover/np_ready/components/discover_grid/discover_grid.tsx
@@ -121,7 +121,7 @@ function CellPopover({
   );
 }
 
-export function DiscoverGrid({
+export const DiscoverGrid = React.memo(function DiscoverGridInner({
   rows,
   columns,
   sort,
@@ -139,17 +139,9 @@ export function DiscoverGrid({
 }: Props) {
   const actionColumnId = 'uniqueString'; // TODO should be guaranteed unique...
   const lowestPageSize = 50;
-  const timeNode = useMemo(
-    () => (
-      <span>
-        {i18n.translate('kbn.discover.timeLabel', {
-          defaultMessage: 'Time',
-        })}
-      </span>
-    ),
-    []
-  );
-  const timeString = useRenderToText(timeNode, 'Time');
+  const timeString = i18n.translate('kbn.discover.timeLabel', {
+    defaultMessage: 'Time',
+  });
   const [flyoutRow, setFlyoutRow] = useState<ElasticSearchHit | undefined>(undefined);
 
   const dataGridColumns = columns.map(
@@ -218,9 +210,14 @@ export function DiscoverGrid({
    * Visibility and order
    */
   const [visibleColumns, setVisibleColumns] = useState(dataGridColumns.map(obj => obj.id));
+  const mounted = React.useRef(false);
   useEffect(() => {
     // every time a column is added, make it visible
-    setVisibleColumns(dataGridColumns.map(obj => obj.id));
+    if (!mounted.current) {
+      mounted.current = true;
+    } else {
+      setVisibleColumns(dataGridColumns.map(obj => obj.id));
+    }
   }, [dataGridColumns.length]); // eslint-disable-line react-hooks/exhaustive-deps
 
   /**
@@ -444,4 +441,4 @@ export function DiscoverGrid({
       )}
     </>
   );
-}
+});
diff --git a/src/legacy/core_plugins/kibana/ui_setting_defaults.js b/src/legacy/core_plugins/kibana/ui_setting_defaults.js
@@ -1163,5 +1163,16 @@ export function getUiSettingDefaults() {
       category: ['accessibility'],
       requiresPageReload: true,
     },
+    'doc_table:legacyTable': {
+      name: i18n.translate('kbn.advancedSettings.docTableVersionName', {
+        defaultMessage: 'Use legacy table',
+      }),
+      value: false,
+      description: i18n.translate('kbn.advancedSettings.docTableVersionDescription', {
+        defaultMessage:
+          'Prefer the legacy version of the documents table in Discover while available',
+      }),
+      category: ['discover'],
+    },
   };
 }