migrate saved object management routes to new plugin

elastic · Mar 3, 2020 · 1f5e057 · 1f5e057
1 parent efe0533
commit 1f5e057
Show file tree

Hide file tree

Showing 29 changed files with 858 additions and 666 deletions.
diff --git a/src/core/server/saved_objects/index.ts b/src/core/server/saved_objects/index.ts
@@ -21,8 +21,6 @@ export * from './service';
 
 export { SavedObjectsSchema } from './schema';
 
-export { SavedObjectsManagement } from './management';
-
 export * from './import';
 
 export {

diff --git a/src/core/server/saved_objects/management/management.test.ts b/src/core/server/saved_objects/management/management.test.ts
diff --git a/src/core/server/saved_objects/management/management.ts b/src/core/server/saved_objects/management/management.ts
diff --git a/src/core/server/saved_objects/saved_objects_service.ts b/src/core/server/saved_objects/saved_objects_service.ts
@@ -452,7 +452,9 @@ export class SavedObjectsService
     };
   }
 
-  public async stop() {}
+  public async stop() {
+    this.migrator$.complete();
+  }
 
   private createMigrator(
     kibanaConfig: KibanaConfigType,

diff --git a/src/core/server/saved_objects/saved_objects_type_registry.mock.ts b/src/core/server/saved_objects/saved_objects_type_registry.mock.ts
@@ -28,11 +28,13 @@ const createRegistryMock = (): jest.Mocked<ISavedObjectTypeRegistry &
     isNamespaceAgnostic: jest.fn(),
     isHidden: jest.fn(),
     getIndex: jest.fn(),
+    isImportableAndExportable: jest.fn(),
   };
 
   mock.getIndex.mockReturnValue('.kibana-test');
   mock.isHidden.mockReturnValue(false);
   mock.isNamespaceAgnostic.mockImplementation((type: string) => type === 'global');
+  mock.isImportableAndExportable.mockReturnValue(true);
 
   return mock;
 };

diff --git a/src/core/server/saved_objects/saved_objects_type_registry.ts b/src/core/server/saved_objects/saved_objects_type_registry.ts
@@ -27,7 +27,12 @@ import { SavedObjectsType } from './types';
  */
 export type ISavedObjectTypeRegistry = Pick<
   SavedObjectTypeRegistry,
-  'getType' | 'getAllTypes' | 'getIndex' | 'isNamespaceAgnostic' | 'isHidden'
+  | 'getType'
+  | 'getAllTypes'
+  | 'getIndex'
+  | 'isNamespaceAgnostic'
+  | 'isHidden'
+  | 'isImportableAndExportable'
 >;
 
 /**

diff --git a/src/legacy/core_plugins/kibana/index.js b/src/legacy/core_plugins/kibana/index.js
@@ -24,7 +24,6 @@ import { promisify } from 'util';
 import { migrations } from './migrations';
 import { importApi } from './server/routes/api/import';
 import { exportApi } from './server/routes/api/export';
-import { managementApi } from './server/routes/api/management';
 import mappings from './mappings.json';
 import { getUiSettingDefaults } from './ui_setting_defaults';
 import { registerCspCollector } from './server/lib/csp_usage_collector';
@@ -322,7 +321,6 @@ export default function(kibana) {
       // routes
       importApi(server);
       exportApi(server);
-      managementApi(server);
       registerCspCollector(usageCollection, server);
       server.injectUiAppVars('kibana', () => injectVars(server));
     },